Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize connect modal #591

Merged
merged 18 commits into from
Mar 14, 2024
Merged

feat: optimize connect modal #591

merged 18 commits into from
Mar 14, 2024

Conversation

LCJove
Copy link
Collaborator

@LCJove LCJove commented Feb 29, 2024

  1. update the modal under the new ued
  2. scroll when wallet list overflow
  3. add qc code at the begin
  4. show extension when it is avaliable
    close ConnectModal support show wallet status #550

image

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6eaee12) to head (e4da53a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #591   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          649       650    +1     
  Lines        17428     17483   +55     
  Branches      1053      1065   +12     
=========================================
+ Hits         17428     17483   +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

changeset-bot bot commented Feb 29, 2024

🦋 Changeset detected

Latest commit: e4da53a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@ant-design/web3-common Minor
@ant-design/web3 Minor
@ant-design/web3-assets Patch
@ant-design/web3-solana Patch
@ant-design/web3-wagmi Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 2:46am

Copy link

github-actions bot commented Feb 29, 2024

@yutingzhao1991
Copy link
Collaborator

image

插件已经安装的情况下点击二维码不应该唤起插件,另外感觉二维码图标应该有一个 hover 效果,这样才更像可以单独点的感觉。

@yutingzhao1991
Copy link
Collaborator

二维码图标 hover 的效果可以找 @wenqing993 对下

packages/common/src/locale/zh_CN.ts Outdated Show resolved Hide resolved
packages/common/src/locale/en_US.ts Outdated Show resolved Hide resolved
packages/web3/src/connect-modal/components/PluginTag.tsx Outdated Show resolved Hide resolved
packages/web3/src/connect-modal/components/PluginTag.tsx Outdated Show resolved Hide resolved
packages/web3/src/connect-modal/components/WalletList.tsx Outdated Show resolved Hide resolved
packages/web3/src/connect-modal/index.tsx Show resolved Hide resolved
@thinkasany
Copy link
Collaborator

thinkasany commented Mar 1, 2024

  1. changelog 可以加一个
  2. pr message title 可以加一下feat: xx, 然后关联一下issue, close improve ConnectModal style #552
  3. 单测覆盖一下
    image

@LCJove LCJove changed the title update connect modal feat: optimize connect modal Mar 1, 2024
@LCJove LCJove marked this pull request as ready for review March 1, 2024 06:20
@LCJove
Copy link
Collaborator Author

LCJove commented Mar 1, 2024

image 插件已经安装的情况下点击二维码不应该唤起插件,另外感觉二维码图标应该有一个 hover 效果,这样才更像可以单独点的感觉。

已添加

@thinkasany
Copy link
Collaborator

  1. changelog 可以加一个
  2. pr message title 可以加一下feat: xx, 然后关联一下issue, close improve ConnectModal style #552
  3. 单测覆盖一下
    image

https://app.codecov.io/gh/ant-design/ant-design-web3/pull/591/blob/packages/web3/src/connect-modal/components/WalletList.tsx

image

@yutingzhao1991
Copy link
Collaborator

解决的问题点一下 resolve

@yutingzhao1991
Copy link
Collaborator

yutingzhao1991 commented Mar 5, 2024

image

这个距离感觉宽了,可以把预览地址给设计师那边走查一下。

@jeasonstudio
Copy link
Collaborator

有时间 rebase/merge 下 main 分支

Co-authored-by: tingzhao.ytz <tingzhao.ytz@antgroup.com>
@yutingzhao1991
Copy link
Collaborator

@jeasonstudio 这个 PR 再看看,这周看看能不能发个版本

@jeasonstudio
Copy link
Collaborator

@jeasonstudio 这个 PR 再看看,这周看看能不能发个版本

我这边没别的问题,交互让设计师看一眼就可以 merge 了 cc @LCJove

Co-authored-by: thinkasany <480968828@qq.com>
@yutingzhao1991
Copy link
Collaborator

@jeasonstudio 这个 PR 再看看,这周看看能不能发个版本

我这边没别的问题,交互让设计师看一眼就可以 merge 了 cc @LCJove

ConnectModal 设计走查整个单独作为一个需求提给设计师吧,下周单独再整体细节优化一下,不然战线拉太长了,这个 PR 先合了。

@yutingzhao1991 yutingzhao1991 merged commit 201c2ec into main Mar 14, 2024
12 checks passed
@yutingzhao1991 yutingzhao1991 deleted the feat/gyz-wallet branch March 14, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConnectModal support show wallet status
5 participants