feat(solana): support wallet-connect and handle connect error #656

@@            Coverage Diff            @@
##              main      #656   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          647       647           
  Lines        19537     19603   +66     
  Branches      1114      1121    +7     
=========================================
+ Hits         19537     19603   +66

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yutingzhao1991 · 2024-03-18T06:00:38Z

我突然想到，有没有可能不用它的这个适配器，感觉它这个有点老了，我们直接用 wallet connect 官方的 https://docs.walletconnect.com/advanced/providers/universal

yutingzhao1991 · 2024-03-18T06:03:36Z

packages/solana/package.json

@@ -43,15 +43,15 @@
    "@ant-design/web3-assets": "workspace:*",
    "@ant-design/web3-common": "workspace:*",
    "@metaplex-foundation/js": "^0.20.1",
+    "@solana/wallet-adapter-base": "^0.9.23",


https://docs.walletconnect.com/advanced/migration-from-v1.x/dapps#solana-labswallet-adapter 好像有个 V2 版本，看看。

看错了，好像就是指到这个的

看错了，好像就是指到这个的

有点乱，代码仓库还转移过组织，来龙去脉有点麻烦 😂

packages/web3/src/solana/index.zh-CN.md

gin-lsl · 2024-03-18T06:23:32Z

我突然想到，有没有可能不用它的这个适配器，感觉它这个有点老了，我们直接用 wallet connect 官方的 https://docs.walletconnect.com/advanced/providers/universal

可以换成这个，代码会多一点

gin-lsl · 2024-03-21T08:05:21Z

更新了一波，现在二维码可以适配我们自己的逻辑了。

对 WalletConnect 支持良好的钱包似乎不多？试了几个，Trust 的体验最好。。

jeasonstudio · 2024-03-26T06:54:06Z

Changeset needs to be included

yutingzhao1991 · 2024-03-26T08:03:43Z

packages/solana/src/wallet-connect-adapter.ts

+export class WalletConnectWalletAdapter extends BaseSignerWalletAdapter {
+  name = WalletConnectWalletName;
+  url = 'https://walletconnect.org';
+  icon =


这个是 walletConnect 的 icon 吗？能不能用 web3-icons 里面的 icon？

gin-lsl · 2024-03-26T12:53:56Z

Changeset needs to be included

done

yutingzhao1991 · 2024-03-27T09:21:47Z

packages/solana/src/wallets/built-in.ts


 export const CoinbaseWallet = () =>
  WalletFactory(new CoinbaseWalletAdapter(), metadata_CoinbaseWallet);
+
 export const PhantomWallet = () => WalletFactory(new PhantomWalletAdapter(), metadata_Phantom);


phantom 钱包可以支持 wallet connect 吗？

jeasonstudio · 2024-04-07T03:35:28Z

#750
可以在这个 PR 里加一下 OKX Wallet 支持 @gin-lsl

gin-lsl · 2024-04-07T05:37:53Z

#750 可以在这个 PR 里加一下 OKX Wallet 支持 @gin-lsl

OKX 实现了 Standard Wallet 标准，适配起来还是需要比较多代码的，建议分开提交

Co-authored-by: thinkasany <480968828@qq.com>

gin-lsl requested review from yutingzhao1991, kiner-tang and jeasonstudio March 18, 2024 05:52

yutingzhao1991 reviewed Mar 18, 2024

View reviewed changes

thinkasany reviewed Mar 18, 2024

View reviewed changes

packages/web3/src/solana/index.zh-CN.md Outdated Show resolved Hide resolved

vercel bot deployed to Preview March 19, 2024 03:39 View deployment

vercel bot deployed to Preview March 21, 2024 08:05 View deployment

vercel bot deployed to Preview March 21, 2024 12:04 View deployment

jeasonstudio approved these changes Mar 22, 2024

View reviewed changes

vercel bot deployed to Preview March 22, 2024 07:53 View deployment

gin-lsl force-pushed the feat/solana-walletconnect branch from f9a4872 to 12f6000 Compare March 26, 2024 06:46

vercel bot deployed to Preview March 26, 2024 06:47 View deployment

jeasonstudio changed the title ~~feat(solana): Support WalletConnect and handle connect error~~ feat(solana): support wallet-connect and handle connect error Mar 26, 2024

yutingzhao1991 reviewed Mar 26, 2024

View reviewed changes

vercel bot deployed to Preview March 26, 2024 08:31 View deployment

vercel bot deployed to Preview March 26, 2024 12:42 View deployment

vercel bot deployed to Preview March 26, 2024 14:12 View deployment

vercel bot deployed to Preview March 26, 2024 14:17 View deployment

vercel bot deployed to Preview March 26, 2024 14:25 View deployment

yutingzhao1991 reviewed Mar 27, 2024

View reviewed changes

gin-lsl force-pushed the feat/solana-walletconnect branch from 789bbb0 to 2b7401d Compare April 7, 2024 04:31

vercel bot deployed to Preview April 7, 2024 05:07 View deployment

gin-lsl and others added 22 commits April 8, 2024 10:47

feat(solana): Support WalletConnect and handle connect error

000263a

Update packages/web3/src/solana/index.zh-CN.md

7ca8c61

Co-authored-by: thinkasany <480968828@qq.com>

feat: add wallet-connect-adapter

87351a3

test: fix test case

d0bf5a3

test: add connect error tests and walletconnect tests

1178f76

docs: add deprecated of PhantomWallet

934e974

refactor: code improve

c7a2aef

chore: add changeset

886f17b

doc: api docs

0de565f

refactor: remove deprecated

1c3782b

refactor: types rename

05f8f0a

refactor: Improve code

d928cac

fix: modal should not close when click WalletConnect again

e6414d2

chore: clean imports

608bfe6

fix: typo

0b7e779

feat: fix walletconnect signMessage params

3054ea1

test: refactor code

aab5cab

doc: add signmessage demo

000e3e9

feat: impl signTransaction

130c209

refactor: improve imports

22f9fd7

feat: re-export useConnection and useAnchorWallet hooks

b1b71d7

chore: update lock file

26c60f2

gin-lsl force-pushed the feat/solana-walletconnect branch from 2b7401d to 26c60f2 Compare April 8, 2024 02:55

vercel bot deployed to Preview April 8, 2024 03:17 View deployment

jeasonstudio merged commit 84181a8 into main Apr 8, 2024
12 checks passed

jeasonstudio deleted the feat/solana-walletconnect branch April 8, 2024 03:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(solana): support wallet-connect and handle connect error #656

feat(solana): support wallet-connect and handle connect error #656

gin-lsl commented Mar 18, 2024

changeset-bot bot commented Mar 18, 2024 •

edited

vercel bot commented Mar 18, 2024 •

edited

github-actions bot commented Mar 18, 2024 •

edited

gin-lsl commented Mar 18, 2024

codecov bot commented Mar 18, 2024 •

edited

yutingzhao1991 commented Mar 18, 2024

yutingzhao1991 Mar 18, 2024

yutingzhao1991 Mar 18, 2024

gin-lsl Mar 18, 2024

gin-lsl commented Mar 18, 2024

gin-lsl commented Mar 21, 2024

jeasonstudio commented Mar 26, 2024

yutingzhao1991 Mar 26, 2024

gin-lsl commented Mar 26, 2024

yutingzhao1991 Mar 27, 2024

jeasonstudio commented Apr 7, 2024

gin-lsl commented Apr 7, 2024

feat(solana): support wallet-connect and handle connect error #656

feat(solana): support wallet-connect and handle connect error #656

Conversation

gin-lsl commented Mar 18, 2024

changeset-bot bot commented Mar 18, 2024 • edited

🦋 Changeset detected

vercel bot commented Mar 18, 2024 • edited

github-actions bot commented Mar 18, 2024 • edited

gin-lsl commented Mar 18, 2024

codecov bot commented Mar 18, 2024 • edited

Codecov Report

yutingzhao1991 commented Mar 18, 2024

yutingzhao1991 Mar 18, 2024

Choose a reason for hiding this comment

yutingzhao1991 Mar 18, 2024

Choose a reason for hiding this comment

gin-lsl Mar 18, 2024

Choose a reason for hiding this comment

gin-lsl commented Mar 18, 2024

gin-lsl commented Mar 21, 2024

jeasonstudio commented Mar 26, 2024

yutingzhao1991 Mar 26, 2024

Choose a reason for hiding this comment

gin-lsl commented Mar 26, 2024

yutingzhao1991 Mar 27, 2024

Choose a reason for hiding this comment

jeasonstudio commented Apr 7, 2024

gin-lsl commented Apr 7, 2024

changeset-bot bot commented Mar 18, 2024 •

edited

vercel bot commented Mar 18, 2024 •

edited

github-actions bot commented Mar 18, 2024 •

edited

codecov bot commented Mar 18, 2024 •

edited