Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support theme-editor #664

Merged
merged 11 commits into from
Mar 22, 2024
Merged

chore: support theme-editor #664

merged 11 commits into from
Mar 22, 2024

Conversation

jeasonstudio
Copy link
Collaborator

@jeasonstudio jeasonstudio commented Mar 18, 2024

路由是:/theme-editor/theme-editor-cn,但目前 previewer 组件不支持多语言,两个路由是同一个页面。

https://preview-664-ant-design-web3.surge.sh/theme-editor
screenshot-D93yIT9X@2x

Copy link

changeset-bot bot commented Mar 18, 2024

⚠️ No Changeset found

Latest commit: 05928dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2024 8:03am

Copy link

github-actions bot commented Mar 18, 2024

@jeasonstudio jeasonstudio changed the title chore: 支持 theme-editor chore: support theme-editor Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b5eccf9) to head (05928dc).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #664   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          651       651           
  Lines        17767     17767           
  Branches      1111      1111           
=========================================
  Hits         17767     17767           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeasonstudio
Copy link
Collaborator Author

@gin-lsl
Copy link
Collaborator

gin-lsl commented Mar 18, 2024

image
切换主题这里似乎不起作用

@yutingzhao1991
Copy link
Collaborator

image

把 antdweb3 的组件都弄出来,antd 自己的都可以去掉。

@thinkasany
Copy link
Collaborator

我感觉我体验起来好像不是很流畅不知道是机子老了还是咋了。
然后这边我多切换几次,右边会出现那个api一直显示在那里
image

@jeasonstudio
Copy link
Collaborator Author

我感觉我体验起来好像不是很流畅不知道是机子老了还是咋了。 然后这边我多切换几次,右边会出现那个api一直显示在那里 image

我把 antd 组件去掉,这两个问题就没有了

@thinkasany
Copy link
Collaborator

我感觉我体验起来好像不是很流畅不知道是机子老了还是咋了。 然后这边我多切换几次,右边会出现那个api一直显示在那里 image

我把 antd 组件去掉,这两个问题就没有了

好嘞,我到时候再来冒烟测试一下

@thinkasany
Copy link
Collaborator

现在好像流畅了 但是这个切换有点奇怪
20240321161034_rec_

@jeasonstudio
Copy link
Collaborator Author

现在好像流畅了 但是这个切换有点奇怪 20240321161034_rec_ 20240321161034_rec_

指的是哪里,这部分跟 antd 原始组件的行为一样:https://ant-design.github.io/antd-token-previewer/previewer

@thinkasany
Copy link
Collaborator

thinkasany commented Mar 21, 2024

是预期内的嘛,习惯性的感觉侧边导航栏点击哪儿个显示哪儿个,这个会滚动下来,如果是预期内的话 那应该没啥问题

@jeasonstudio
Copy link
Collaborator Author

是预期内的嘛,习惯性的感觉侧边导航栏点击哪儿个显示哪儿个,这个会滚动下来,如果是预期内的话 那应该没啥问题

嗯嗯,算是预期内的

@yutingzhao1991
Copy link
Collaborator

感觉没必要把所有的 Demo 都展示出来,这里主要暂时体现 UI 风格的都行。感觉针对性的写五六个组件 demo 就够了。

@jeasonstudio
Copy link
Collaborator Author

感觉没必要把所有的 Demo 都展示出来,这里主要暂时体现 UI 风格的都行。感觉针对性的写五六个组件 demo 就够了。

目前也不多,需要给出新的 token 在各个组件的各个状态下的预览,否则配置主题时需要跳来跳去

@jeasonstudio jeasonstudio merged commit dad373b into main Mar 22, 2024
12 checks passed
@jeasonstudio jeasonstudio deleted the feat-support-theme-editor branch March 22, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants