Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: icon svg style error #672

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix: icon svg style error #672

merged 1 commit into from
Mar 21, 2024

Conversation

yutingzhao1991
Copy link
Collaborator

[中文版模板 / Chinese template]

📝 Git Commit Message Convention

react-inline-svg-unique-id 这个插件识别不了 styles= 的语法,这个语法也不够规范。试了改了一下这样就好了。

先改了这个,后面把别的也改一下。看看能不能有什么自动的工具或者给这个插件提个 PR 来支持下这种预发。

🔗 Related issue link

close #666

Copy link

changeset-bot bot commented Mar 20, 2024

🦋 Changeset detected

Latest commit: 7942403

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@ant-design/web3-icons Patch
@ant-design/web3-assets Patch
@ant-design/web3 Patch
@ant-design/web3-solana Patch
@ant-design/web3-wagmi Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2024 3:40am

Copy link

github-actions bot commented Mar 20, 2024

@thinkasany
Copy link
Collaborator

话说这样子每个图片都改一下 是不是工作量有点大

revert 之前那个配置是可以用的

#616

@jeasonstudio
Copy link
Collaborator

GitHub 的 WIP 在标题上加是没用的,需要点一下右侧的 Convert to draft

@yutingzhao1991 yutingzhao1991 marked this pull request as draft March 21, 2024 02:22
@yutingzhao1991 yutingzhao1991 changed the title [WIP] fix: icon svg style error fix: icon svg style error Mar 21, 2024
@yutingzhao1991 yutingzhao1991 marked this pull request as ready for review March 21, 2024 03:03
@yutingzhao1991
Copy link
Collaborator Author

话说这样子每个图片都改一下 是不是工作量有点大

revert 之前那个配置是可以用的

#616

revert 会有别的问题,那个 PR 是为了修另外一个问题的

@kiner-tang
Copy link
Member

react-inline-svg-unique-id

或许可以给这个插件提个 pr 支持一下 style 中的 id 解析

@yutingzhao1991
Copy link
Collaborator Author

react-inline-svg-unique-id

或许可以给这个插件提个 pr 支持一下 style 中的 id 解析

嗯,后面我看看能不能搞

@thinkasany
Copy link
Collaborator

好像快照还需要更新一下
image

@jeasonstudio
Copy link
Collaborator

Workout, 这么多都是手改的吗 :)

@yutingzhao1991
Copy link
Collaborator Author

Workout, 这么多都是手改的吗 :)

一个正则

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d374e55) to head (7942403).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #672   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          650       650           
  Lines        17505     17506    +1     
  Branches      1071      1071           
=========================================
+ Hits         17505     17506    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yutingzhao1991 yutingzhao1991 merged commit ec92a76 into main Mar 21, 2024
12 checks passed
@yutingzhao1991 yutingzhao1991 deleted the fix/iconstyle branch March 21, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: web3-icon 部分图标显示空白
4 participants