-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(card): use styles.body
instead of bodyStyle
#681
Conversation
🦋 Changeset detectedLatest commit: 0c99cc4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
目前 antd 是作为 @ant-design/web3
的 dependencies
,并且版本支持 styles.body
,基于此前提这个 PR 是没问题的。
但作为 antd 的上层封装,我们应该将 antd 作为 peerDependencies
,并且做好一定的兼容,类似的项目比如 pro-components
也是这么做的:
https://github.com/ant-design/pro-components/blob/master/packages/components/package.json#L51
可以讨论下。
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #681 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 651 651
Lines 17769 17769
Branches 1113 1113
=========================================
Hits 17769 17769 ☔ View full report in Codecov by Sentry. |
目前咱们这个项目立项之初就是基于 |
我看文档, |
这个 pr 改的是 demo 里面的代码 |
但是感觉给用户推荐一个demo,结果人家运行的时候 还有一个废弃的 warn 感觉怪怪的。不过也的确是替换了之后对版本要求有点高。 |
官方 demo 尽量给用户最正确的引导 |
pro 这么做是为了兼容 antd4,我们应该不需要 |
替换移除的api