Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: img add default alt and format table #694

Merged
merged 10 commits into from
Mar 26, 2024
Merged

docs: img add default alt and format table #694

merged 10 commits into from
Mar 26, 2024

Conversation

zhouyou12
Copy link
Contributor

[中文版模板 / Chinese template]

📝 Git Commit Message Convention

This is adapted from Angular's commit convention.

🔗 Related issue link

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2024 •
edited

⚠️ No Changeset found

Latest commit: f68806e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 25, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 3:20am

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2024 •
edited

kiner-tang
kiner-tang reviewed Mar 25, 2024
View reviewed changes
docs/course/contract-compile-deploy.md Outdated
@@ -47,11 +47,11 @@ Click the drop-down box of `ENVIRONMENT`, you can see many options to choose fro

Then, `MetaMask` will pop up a window and prompt to connect it to `Remix`. After connecting `MetaMask` to `Remix`, the side panel will be updated to display the connected network and account. Deploying to the testnet also requires testnet tokens. You can find the corresponding testnet token faucet on the network for recharging.

<img src='./img/changeNode.png' width="33%">
<img src='./img/changeNode.png' width="33%" alt="">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

既然加了 alt 属性，就不要弄空字符串吧，根据图片内容写个概要放在 alt 里面

@kiner-tang kiner-tang changed the title 文档:img添加alt默认字段，格式化表格 docs: img 添加alt默认字段，格式化表格 Mar 25, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 25, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (efd6bbd) to head (f68806e).

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #694   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          651       651           
  Lines        17769     17769           
  Branches      1113      1113           
=========================================
  Hits         17769     17769

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jeasonstudio
jeasonstudio previously requested changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@jeasonstudio jeasonstudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title 需要改为符合 commit lint 格式的英文标题，squash merge 后风格统一

thinkasany
thinkasany reviewed Mar 26, 2024
View reviewed changes
docs/course/contract-compile-deploy.md Outdated Show resolved Hide resolved
docs/course/contract-compile-deploy.md Outdated Show resolved Hide resolved
docs/course/contract-compile-deploy.md Outdated Show resolved Hide resolved
docs/course/contract-compile-deploy.zh-CN.md Outdated Show resolved Hide resolved
@thinkasany thinkasany changed the title docs: img 添加alt默认字段，格式化表格 docs: img add default alt and format table Mar 26, 2024
@thinkasany thinkasany merged commit da02146 into ant-design:main Mar 26, 2024
8 checks passed
@thinkasany
Copy link
Collaborator

@zhouyou12 Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiner-tang kiner-tang kiner-tang left review comments

@jeasonstudio jeasonstudio jeasonstudio approved these changes

@thinkasany thinkasany thinkasany approved these changes

@yutingzhao1991 yutingzhao1991 Awaiting requested review from yutingzhao1991

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhouyou12 @thinkasany @kiner-tang @jeasonstudio