Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: img add default alt (#705) #707

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Conversation

chenjixue
Copy link
Contributor

[中文版模板 / Chinese template]

📝 Git Commit Message Convention

This is adapted from Angular's commit convention.

🔗 Related issue link

#705

Copy link

changeset-bot bot commented Mar 26, 2024

🦋 Changeset detected

Latest commit: 8f562eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ant-design/web3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 10:26am

Copy link

github-actions bot commented Mar 26, 2024

@@ -1,6 +1,6 @@
<div align="center">

<img height="180" src="https://github.com/ant-design/ant-design/assets/507615/12d2c16d-92b1-4202-ba6f-4da5ee3622ba">
<img height="180" alt="ant design web3 logo" src="https://github.com/ant-design/ant-design/assets/507615/12d2c16d-92b1-4202-ba6f-4da5ee3622ba">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

保持一致吧,这边也可以加
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已保持一致

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

搜索一下全局吧 多加几个地方,只加一个地方的话。太少了我们不处理的。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@kiner-tang
Copy link
Member

@chenjixue 有时间的话可以搜索一下项目文档中所有没有 alt 的 img 标签,顺带都加上

Copy link
Contributor Author

@chenjixue chenjixue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

中英文介绍文档顶部log图片alt描述信息都已保持一致

@chenjixue chenjixue marked this pull request as ready for review March 26, 2024 09:30
@chenjixue
Copy link
Contributor Author

@chenjixue 有时间的话可以搜索一下项目文档中所有没有 alt 的 img 标签,顺带都加上

暂时未发现其他Img需要添加alt

@kiner-tang
Copy link
Member

@chenjixue 有时间的话可以搜索一下项目文档中所有没有 alt 的 img 标签,顺带都加上

暂时未发现其他Img需要添加alt

image
<img\b(?![^>]*alt=)[^>]*>

可以尝试用这个正则全局搜索一下,目前看着还是有一些的

@@ -0,0 +1,5 @@
---
"@ant-design/web3": major
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不能用 major 版本了,用 patch 版本吧

@kiner-tang kiner-tang merged commit bb5ca37 into ant-design:main Mar 26, 2024
6 checks passed
Copy link

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us.

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们。

Ant Design Web3 Community Group QCcode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants