feat: support more icons #738

thinkasany · 2024-03-29T03:03:33Z

我们迎来了很多新的icon 🎉

vercel · 2024-03-29T03:03:37Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ant-design-web3	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 19, 2024 8:56am

changeset-bot · 2024-03-29T03:03:37Z

🦋 Changeset detected

Latest commit: 948064d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
@ant-design/web3-icons	Minor
@ant-design/web3-assets	Patch
@ant-design/web3	Patch
@ant-design/web3-ethers	Patch
@ant-design/web3-solana	Patch
@ant-design/web3-wagmi	Patch
@example/ethers-v5	Patch
@example/ethers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-03-29T03:03:45Z

.changeset/tiny-beers-destroy.md

packages/icons/src/svgs/bitcoin-colorful.svg

LCJove · 2024-03-29T07:25:19Z

可以在配置中加一个这个：

 extraBabelPlugins: [['inline-react-svg', {
    svgo: {
      plugin: {
        name: 'preset-default',
        params: {
          overrides: {
            removeViewBox: false,
          },
        },
      },
    }
  }], 'react-inline-svg-unique-id'],

试一试看

thinkasany · 2024-03-29T07:31:24Z

可以在配置中加一个这个：

 extraBabelPlugins: [['inline-react-svg', {
    svgo: {
      plugin: {
        name: 'preset-default',
        params: {
          overrides: {
            removeViewBox: false,
          },
        },
      },
    }
  }], 'react-inline-svg-unique-id'],

试一试看

这个我尝试过了不行，svgo并不是我们直接依赖的，我猜测是不是antd-icon那边导致的，所以只能尝试修改svg格式了？

LCJove · 2024-03-29T07:55:39Z

再加一个删height和width的配置看看？我用了这个配置在本地是好的了

extraBabelPlugins: [['inline-react-svg', {
    svgo: {
      plugins: [{
        name: 'preset-default',
        params: {
          overrides: {
            removeViewBox: false,
          },
        },
      }, "removeDimensions"]
    }
  }], 'react-inline-svg-unique-id'],

我看inline-react-svg这个是会用到svgo的配置
另外我发现直接修改svg页面不会主动刷新，还是要去tsx那边保存才刷新，搞得我以为修改没用😢

LCJove · 2024-03-29T08:04:11Z

我还发现了一些icon不展示的原因是它们把 fill 写到了 style 里面，导致引用的时候丢失了这部分的颜色
需要把 fill 从 style 里面拿出来

svgo: {
      plugins: [{
        name: 'preset-default',
        params: {
          overrides: {
            removeViewBox: false,
          },
        },
      }, "removeDimensions", "convertStyleToAttrs"]
    }

可以用这个 convertStyleToAttrs 把 fill 拎出来

thinkasany · 2024-03-29T08:09:54Z

再加一个删height和width的配置看看？我用了这个配置在本地是好的了
extraBabelPlugins: [['inline-react-svg', {
    svgo: {
      plugins: [{
        name: 'preset-default',
        params: {
          overrides: {
            removeViewBox: false,
          },
        },
      }, "removeDimensions"]
    }
  }], 'react-inline-svg-unique-id'],
我看inline-react-svg这个是会用到svgo的配置另外我发现直接修改svg页面不会主动刷新，还是要去tsx那边保存才刷新，搞得我以为修改没用😢

噢噢那我可能也是没去tsx保存刷新，所以改动看不出来

codecov · 2024-03-29T09:15:43Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1c05b0c) to head (6fed314).
Report is 1 commits behind head on main.

❗ Current head 6fed314 differs from pull request most recent head 948064d. Consider uploading reports for the commit 948064d to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##              main      #738     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          666       684     +18     
  Lines        20264     18483   -1781     
  Branches      1155      1137     -18     
===========================================
- Hits         20264     18483   -1781

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jeasonstudio · 2024-03-29T09:23:02Z

packages/icons/src/components/dot-circle-colorful.tsx

+
+import SVGComponent from '../svgs/dot-circle-colorful.svg';
+
+export const DotCircleColorful = React.forwardRef<HTMLSpanElement, IconBaseProps>((props, ref) => {


这个组件的效果好像不符合命名：

意思是改成DOT是嘛

我想表达的是如果被命名为 XxxCircleColorful，那么这个图标的外层应该是一个完整的圆形为包裹，但 dot 的不符合

jeasonstudio · 2024-03-29T09:25:02Z

packages/icons/src/components/near-circle-filled.tsx

+
+import SVGComponent from '../svgs/near-circle-filled.svg';
+
+export const NearCircleFilled = React.forwardRef<HTMLSpanElement, IconBaseProps>((props, ref) => {


near 的大小也有点怪，这两张图是同比例尺的

jeasonstudio · 2024-03-29T09:26:11Z

packages/icons/src/components/shib-circle-colorful.tsx

+
+import SVGComponent from '../svgs/shib-circle-colorful.svg';
+
+export const ShibCircleColorful = React.forwardRef<HTMLSpanElement, IconBaseProps>((props, ref) => {


shib 的 circle colorful 和 circle filled 好像不符合规则，不行就直接去掉，保留 colorful

jeasonstudio · 2024-03-29T09:27:33Z

还有许多 icon 的 circle colorfull 和 circle filled 的展示大小不一样，这个可能要请设计师帮忙看看 @文卿

yutingzhao1991 · 2024-04-10T09:38:43Z

这个还是 draft 吗？是不是可以合并了？

yutingzhao1991 · 2024-04-10T09:40:03Z

样式不对的可以找文卿帮忙调整下，或者先去掉，推进下这个 PR 继续~

thinkasany · 2024-04-10T09:42:35Z

样式不对的可以找文卿帮忙调整下，或者先去掉，推进下这个 PR 继续~

我之前开发了一个generate脚本，我重新刷一下目录，然后和设计沟通一下进度，推进一下

thinkasany marked this pull request as draft March 29, 2024 03:03

kiner-tang reviewed Mar 29, 2024

View reviewed changes

.changeset/tiny-beers-destroy.md Outdated Show resolved Hide resolved

vercel bot deployed to Preview March 29, 2024 03:05 View deployment

yutingzhao1991 reviewed Mar 29, 2024

View reviewed changes

packages/icons/src/svgs/bitcoin-colorful.svg Show resolved Hide resolved

thinkasany mentioned this pull request Mar 29, 2024

chore(BabelPlugins): overrides configuration for svgo #742

Merged

thinkasany force-pushed the icon branch from d16f5c0 to 8d39706 Compare March 29, 2024 08:36

vercel bot deployed to Preview March 29, 2024 08:39 View deployment

vercel bot deployed to Preview March 29, 2024 08:41 View deployment

vercel bot deployed to Preview March 29, 2024 09:10 View deployment

thinkasany requested review from yutingzhao1991, kiner-tang and jeasonstudio March 29, 2024 09:16

thinkasany marked this pull request as ready for review March 29, 2024 09:17

kiner-tang approved these changes Mar 29, 2024

View reviewed changes

jeasonstudio reviewed Mar 29, 2024

View reviewed changes

thinkasany marked this pull request as draft March 29, 2024 09:25

jeasonstudio reviewed Mar 29, 2024

View reviewed changes

yutingzhao1991 approved these changes Apr 10, 2024

View reviewed changes

thinkasany force-pushed the icon branch from 6fed314 to 7cceeee Compare April 10, 2024 10:11

vercel bot deployed to Preview April 10, 2024 10:14 View deployment

vercel bot deployed to Preview April 10, 2024 10:17 View deployment

vercel bot deployed to Preview April 10, 2024 10:21 View deployment

thinkasany force-pushed the icon branch from 982321a to 63eba54 Compare April 10, 2024 13:18

vercel bot deployed to Preview April 10, 2024 13:20 View deployment

thinkasany added 2 commits April 19, 2024 16:48

feat: support more icons

63de2d3

docs: add changelog

4bbee72

thinkasany force-pushed the icon branch from 63eba54 to 4bbee72 Compare April 19, 2024 08:48

jeasonstudio marked this pull request as ready for review April 19, 2024 08:49

jeasonstudio approved these changes Apr 19, 2024

View reviewed changes

vercel bot deployed to Preview April 19, 2024 08:50 View deployment

thinkasany added 2 commits April 19, 2024 16:52

chore: update snap

d279a59

fix: update

948064d

vercel bot deployed to Preview April 19, 2024 08:56 View deployment

jeasonstudio merged commit 7fbf83a into ant-design:main Apr 19, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support more icons #738

feat: support more icons #738

thinkasany commented Mar 29, 2024 •

edited

vercel bot commented Mar 29, 2024 •

edited

changeset-bot bot commented Mar 29, 2024 •

edited

github-actions bot commented Mar 29, 2024 •

edited

LCJove commented Mar 29, 2024 •

edited

thinkasany commented Mar 29, 2024

LCJove commented Mar 29, 2024

LCJove commented Mar 29, 2024 •

edited

thinkasany commented Mar 29, 2024

codecov bot commented Mar 29, 2024 •

edited

jeasonstudio Mar 29, 2024

thinkasany Mar 29, 2024

jeasonstudio Mar 29, 2024

jeasonstudio Mar 29, 2024

jeasonstudio Mar 29, 2024

jeasonstudio commented Mar 29, 2024

yutingzhao1991 commented Apr 10, 2024

yutingzhao1991 commented Apr 10, 2024

thinkasany commented Apr 10, 2024


		import SVGComponent from '../svgs/dot-circle-colorful.svg';

		export const DotCircleColorful = React.forwardRef<HTMLSpanElement, IconBaseProps>((props, ref) => {


		import SVGComponent from '../svgs/near-circle-filled.svg';

		export const NearCircleFilled = React.forwardRef<HTMLSpanElement, IconBaseProps>((props, ref) => {


		import SVGComponent from '../svgs/shib-circle-colorful.svg';

		export const ShibCircleColorful = React.forwardRef<HTMLSpanElement, IconBaseProps>((props, ref) => {

feat: support more icons #738

feat: support more icons #738

Conversation

thinkasany commented Mar 29, 2024 • edited

vercel bot commented Mar 29, 2024 • edited

changeset-bot bot commented Mar 29, 2024 • edited

🦋 Changeset detected

github-actions bot commented Mar 29, 2024 • edited

LCJove commented Mar 29, 2024 • edited

thinkasany commented Mar 29, 2024

LCJove commented Mar 29, 2024

LCJove commented Mar 29, 2024 • edited

thinkasany commented Mar 29, 2024

codecov bot commented Mar 29, 2024 • edited

Codecov Report

jeasonstudio Mar 29, 2024

Choose a reason for hiding this comment

thinkasany Mar 29, 2024

Choose a reason for hiding this comment

jeasonstudio Mar 29, 2024

Choose a reason for hiding this comment

jeasonstudio Mar 29, 2024

Choose a reason for hiding this comment

jeasonstudio Mar 29, 2024

Choose a reason for hiding this comment

jeasonstudio commented Mar 29, 2024

yutingzhao1991 commented Apr 10, 2024

yutingzhao1991 commented Apr 10, 2024

thinkasany commented Apr 10, 2024

thinkasany commented Mar 29, 2024 •

edited

vercel bot commented Mar 29, 2024 •

edited

changeset-bot bot commented Mar 29, 2024 •

edited

github-actions bot commented Mar 29, 2024 •

edited

LCJove commented Mar 29, 2024 •

edited

LCJove commented Mar 29, 2024 •

edited

codecov bot commented Mar 29, 2024 •

edited