-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support more icons #738
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 948064d The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
可以在配置中加一个这个:
试一试看 |
这个我尝试过了不行,svgo并不是我们直接依赖的,我猜测是不是antd-icon那边导致的,所以只能尝试修改svg格式了? |
再加一个删height和width的配置看看?我用了这个配置在本地是好的了
我看inline-react-svg这个是会用到svgo的配置 |
我还发现了一些icon不展示的原因是它们把 fill 写到了 style 里面,导致引用的时候丢失了这部分的颜色
可以用这个 convertStyleToAttrs 把 fill 拎出来 |
噢噢 那我可能也是没去tsx保存刷新,所以改动看不出来 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 666 684 +18
Lines 20264 18483 -1781
Branches 1155 1137 -18
===========================================
- Hits 20264 18483 -1781 ☔ View full report in Codecov by Sentry. |
|
||
import SVGComponent from '../svgs/dot-circle-colorful.svg'; | ||
|
||
export const DotCircleColorful = React.forwardRef<HTMLSpanElement, IconBaseProps>((props, ref) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我想表达的是如果被命名为 XxxCircleColorful
,那么这个图标的外层应该是一个完整的圆形为包裹,但 dot 的不符合
|
||
import SVGComponent from '../svgs/near-circle-filled.svg'; | ||
|
||
export const NearCircleFilled = React.forwardRef<HTMLSpanElement, IconBaseProps>((props, ref) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
import SVGComponent from '../svgs/shib-circle-colorful.svg'; | ||
|
||
export const ShibCircleColorful = React.forwardRef<HTMLSpanElement, IconBaseProps>((props, ref) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shib 的 circle colorful 和 circle filled 好像不符合规则,不行就直接去掉,保留 colorful
还有许多 icon 的 circle colorfull 和 circle filled 的展示大小不一样,这个可能要请设计师帮忙看看 @文卿 |
这个还是 draft 吗?是不是可以合并了? |
样式不对的可以找文卿帮忙调整下,或者先去掉,推进下这个 PR 继续~ |
我之前开发了一个generate脚本,我重新刷一下目录,然后和设计沟通一下进度,推进一下 |
我们迎来了很多新的icon 🎉