Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize connect modal UI #776

Merged
merged 5 commits into from
Apr 11, 2024
Merged

feat: optimize connect modal UI #776

merged 5 commits into from
Apr 11, 2024

Conversation

LCJove
Copy link
Collaborator

@LCJove LCJove commented Apr 8, 2024

[中文版模板 / Chinese template]

💡 Background and solution

对connect modal 的一些优化工作,

  1. 整体的高度不会变化,因此需要对一些内容添加overflow
  2. 插件的按钮的位置进行优化,避免右侧出现大量空白
  3. 钱包名字过长时,省略展示

🔗 Related issue link

close #653

Copy link

changeset-bot bot commented Apr 8, 2024

🦋 Changeset detected

Latest commit: 455060a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ant-design/web3 Minor
@example/ethers-v5 Patch
@example/ethers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2024 3:45am

Copy link

github-actions bot commented Apr 8, 2024

Preview is ready

Copy link
Member

@kiner-tang kiner-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

要不添加一个测试用例测试一下文案超出省略的情况,或者是加一个 demo 感觉也可以

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b1b8a46) to head (455060a).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #776    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          647       649     +2     
  Lines        19537     19736   +199     
  Branches      1114      1122     +8     
==========================================
+ Hits         19537     19736   +199     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thinkasany
Copy link
Collaborator

高度会不会不太够,感觉这个还是能够同时显示俩个好看。
image

@LCJove LCJove merged commit b7668e3 into main Apr 11, 2024
12 checks passed
@LCJove LCJove deleted the feat-connect-modal-ui branch April 11, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConnectModal UI Detail Issues Feedback
4 participants