-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optimize connect modal UI #776
Conversation
🦋 Changeset detectedLatest commit: 455060a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
要不添加一个测试用例测试一下文案超出省略的情况,或者是加一个 demo 感觉也可以
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 647 649 +2
Lines 19537 19736 +199
Branches 1114 1122 +8
==========================================
+ Hits 19537 19736 +199 ☔ View full report in Codecov by Sentry. |
[中文版模板 / Chinese template]
💡 Background and solution
对connect modal 的一些优化工作,
🔗 Related issue link
close #653