Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scroll layer2 chains and icons #777

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

jeasonstudio
Copy link
Collaborator

[中文版模板 / Chinese template]

💡 Background and solution

默认添加了 Scroll 和 Scroll Sepolia Testnet 两个 Chain 和对应的 icons。后续可以在 Scroll Ecosystem 中展示一下:
https://scroll.io/ecosystem

Copy link

changeset-bot bot commented Apr 8, 2024

🦋 Changeset detected

Latest commit: cb57d78

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@ant-design/web3-assets Patch
@ant-design/web3-common Patch
@ant-design/web3-icons Patch
@ant-design/web3-ethers Patch
@ant-design/web3-solana Patch
@ant-design/web3-wagmi Patch
@ant-design/web3 Patch
@example/ethers-v5 Patch
@example/ethers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 2:23am

Copy link

github-actions bot commented Apr 8, 2024

Preview is ready

Copy link
Member

@kiner-tang kiner-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

要不要加一些测试用例测试一下对新链的支持

@jeasonstudio
Copy link
Collaborator Author

要不要加一些测试用例测试一下对新链的支持

新加的几条都是 evm 兼容链,实际就是一些配置,没什么可测的

@kiner-tang
Copy link
Member

要不要加一些测试用例测试一下对新链的支持

新加的几条都是 evm 兼容链,实际就是一些配置,没什么可测的

👌🏻

@kiner-tang
Copy link
Member

ci 挂了要看看

@thinkasany
Copy link
Collaborator

thinkasany commented Apr 8, 2024

看样子是需要更新一下快照,好像有新增icon。

image

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8ccb094) to head (cb57d78).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #777   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          647       649    +2     
  Lines        19603     19694   +91     
  Branches      1121      1123    +2     
=========================================
+ Hits         19603     19694   +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeasonstudio jeasonstudio merged commit dfef374 into main Apr 9, 2024
12 checks passed
@jeasonstudio jeasonstudio deleted the feat-support-scroll-chains branch April 9, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants