Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(solana): Support auto add registered wallets #799

Merged
merged 6 commits into from
Apr 19, 2024

Conversation

gin-lsl
Copy link
Collaborator

@gin-lsl gin-lsl commented Apr 15, 2024

[中文版模板 / Chinese template]

💡 Background and solution

可以自动将用户已经在浏览器安装插件的钱包添加到 Wallet Lists 中。

image

API 变更

  • 在 SolanaWeb3ConfigProvider 添加了一个 autoAddRegisteredWallets 属性,默认为 false

Copy link

changeset-bot bot commented Apr 15, 2024

🦋 Changeset detected

Latest commit: af4d606

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ant-design/web3-solana Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 7:07am

Copy link

github-actions bot commented Apr 15, 2024

Preview is ready

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (22bb60e) to head (af4d606).

Additional details and impacted files
@@             Coverage Diff             @@
##           main      #799        +/-   ##
===========================================
+ Coverage      0   100.00%   +100.00%     
===========================================
  Files         0       666       +666     
  Lines         0     20265     +20265     
  Branches      0      1156      +1156     
===========================================
+ Hits          0     20265     +20265     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gin-lsl
Copy link
Collaborator Author

gin-lsl commented Apr 15, 2024

这里应该没有必要跟 wagmi 那边的属性保持一致?

TODO:

  • 图标有点大
  • test case
  • 文档补充

@gin-lsl gin-lsl marked this pull request as ready for review April 15, 2024 13:03
@yutingzhao1991
Copy link
Collaborator

这里应该没有必要跟 wagmi 那边的属性保持一致?

TODO:

  • 图标有点大
  • test case
  • 文档补充

尽可能保持一样的风格,但是不需要强行保持一致

@gin-lsl gin-lsl changed the title feat(solana): Support auto add installed wallets feat(solana): Support auto add registered wallets Apr 19, 2024
@gin-lsl gin-lsl merged commit af35e85 into main Apr 19, 2024
12 checks passed
@gin-lsl gin-lsl deleted the feat/solana-auto-registered-wallets branch April 19, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants