-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove unused code #802
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
标题应该叫修复 ci ? |
刚好有一个unused code hhh,我后面拆一个指定版本的pr就好了 |
.github/workflows/ci.yml
Outdated
@@ -16,7 +16,7 @@ jobs: | |||
|
|||
- name: ci | |||
run: | | |||
npm i pnpm -g | |||
npm i pnpm@8.9.0 -g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
指定版本的原因是啥?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
主要是以后可能pnpm升级一次 会不会就出现一次这样子的问题呢 所以感觉会不会指定一下稳定点
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
哦,pnpm 发了大版本啊。
应该可以改为 pnpm@8
先解决这个问题。
升级 pnpm 可以单独提 PR。
3c96a58
to
bca164e
Compare
06423cc
to
4f3bcff
Compare
No description provided.