Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unused code #802

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: remove unused code #802

merged 1 commit into from
Apr 17, 2024

Conversation

thinkasany
Copy link
Collaborator

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2024 •
edited

⚠️ No Changeset found

Latest commit: 4f3bcff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 17, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 7:49am

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited

Preview is ready

@gin-lsl
Copy link
Collaborator

gin-lsl commented Apr 17, 2024

标题应该叫修复 ci ？

@thinkasany
Copy link
Collaborator Author

标题应该叫修复 ci ？

刚好有一个unused code hhh，我后面拆一个指定版本的pr就好了

yutingzhao1991
yutingzhao1991 reviewed Apr 17, 2024
View reviewed changes
.github/workflows/ci.yml Outdated
@@ -16,7 +16,7 @@ jobs:

- name: ci
run: |
npm i pnpm -g
npm i pnpm@8.9.0 -g
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

指定版本的原因是啥？

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在会出现这个报错，还是说把这个升级了
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

主要是以后可能pnpm升级一次 会不会就出现一次这样子的问题呢 所以感觉会不会指定一下稳定点

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哦，pnpm 发了大版本啊。

应该可以改为 pnpm@8 先解决这个问题。

升级 pnpm 可以单独提 PR。

@thinkasany thinkasany merged commit 22bb60e into ant-design:main Apr 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gin-lsl gin-lsl gin-lsl approved these changes

@kiner-tang kiner-tang Awaiting requested review from kiner-tang

@jeasonstudio jeasonstudio Awaiting requested review from jeasonstudio

@yutingzhao1991 yutingzhao1991 Awaiting requested review from yutingzhao1991

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thinkasany @gin-lsl @yutingzhao1991