Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add modal connect status and remove init wallet button #806

Merged
merged 19 commits into from
Apr 19, 2024

Conversation

LCJove
Copy link
Collaborator

@LCJove LCJove commented Apr 18, 2024

[中文版模板 / Chinese template]

💡 Background and solution

  1. 添加了modal在连接时候的loading状态,先用Spin,后续设计稿更新之后再更新
  2. 移除了modal首页的钱包按钮

🔗 Related issue link

close #787

Copy link

changeset-bot bot commented Apr 18, 2024

🦋 Changeset detected

Latest commit: 7eb06fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@ant-design/web3-common Minor
@ant-design/web3 Minor
@ant-design/web3-assets Patch
@ant-design/web3-ethers Patch
@ant-design/web3-solana Patch
@ant-design/web3-wagmi Patch
@example/ethers-v5 Patch
@example/ethers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2024 3:33am

Copy link

github-actions bot commented Apr 18, 2024

Preview is ready

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (22bb60e) to head (7eb06fb).

Additional details and impacted files
@@            Coverage Diff            @@
##           main     #806       +/-   ##
=========================================
+ Coverage      0   99.97%   +99.97%     
=========================================
  Files         0      666      +666     
  Lines         0    20222    +20222     
  Branches      0     1142     +1142     
=========================================
+ Hits          0    20216    +20216     
- Misses        0        6        +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yutingzhao1991
Copy link
Collaborator

image

Learn More 的样式感觉有问题

Copy link
Member

@kiner-tang kiner-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image 感觉这种情况样式得优化一下

@yutingzhao1991
Copy link
Collaborator

image 感觉这种情况样式得优化一下

这种情况应该是没有找到可以下载的 APP 或者浏览器插件,确实可能出现。可以在这个文字上面在加图片或者其他什么提示,看上去协调一点,可以反馈给设计师后面补充下这种情况的设计稿。

@LCJove LCJove merged commit 7fb2d02 into main Apr 19, 2024
12 checks passed
@LCJove LCJove deleted the feat-connect-modal-ui branch April 19, 2024 08:54
size="large"
type="primary"
className={`${prefixCls}-get-btn`}
onClick={() => updatePanelRoute('getWallet')}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在好像不存在panelRoute为‘getWallet’的情况,导致单测覆盖率无法到100%了,想问一下,那这段代码是可以移除了么
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] connect modal optimize
4 participants