Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Connecting logo need to adapt base64 img #897

Merged
merged 7 commits into from
May 29, 2024
Merged

fix: Connecting logo need to adapt base64 img #897

merged 7 commits into from
May 29, 2024

Conversation

gin-lsl
Copy link
Collaborator

@gin-lsl gin-lsl commented May 21, 2024

[中文版模板 / Chinese template]

After
image

💡 Background and solution

close #896

🔗 Related issue link

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 0:02am

Copy link

changeset-bot bot commented May 21, 2024

🦋 Changeset detected

Latest commit: 4a743eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ant-design/web3 Patch
@example/eth-web3js Patch
@example/ethers-v5 Patch
@example/ethers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

github-actions bot commented May 21, 2024

Preview is ready

@yutingzhao1991
Copy link
Collaborator

icon 的大小要再看看,我看 MetaMask 是这样的:

image

@gin-lsl
Copy link
Collaborator Author

gin-lsl commented May 21, 2024

@LCJove 调整了些微样式,看看是否可以这样?

@LCJove
Copy link
Collaborator

LCJove commented May 22, 2024

@LCJove 调整了些微样式,看看是否可以这样?

这个哪里可以看到例子呀

@thinkasany
Copy link
Collaborator

ci挂了需要看看, 看起来可能是需要更新一下快照
image

@gin-lsl
Copy link
Collaborator Author

gin-lsl commented May 22, 2024

@LCJove 调整了些微样式,看看是否可以这样?

这个哪里可以看到例子呀

单就我说的样式修改的话,无论哪个都可以的。修改了连接中时,显示的图标大小。

@gin-lsl
Copy link
Collaborator Author

gin-lsl commented May 22, 2024

奇怪,本地是能够通过的

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8e0aa43) to head (4a743eb).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #897   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          708       709    +1     
  Lines        21461     21477   +16     
  Branches      1214      1215    +1     
=========================================
+ Hits         21461     21477   +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gin-lsl
Copy link
Collaborator Author

gin-lsl commented May 22, 2024

奇怪,本地是能够通过的

可以了,竟然是需要重新 install 一下……

@gin-lsl gin-lsl merged commit 8478fbd into main May 29, 2024
12 checks passed
@gin-lsl gin-lsl deleted the feat/dev branch May 29, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]Connecting logo need to adapt base64 img
5 participants