feat(bitcoin): add getInscription API and enhance types #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmAzing129
requested review from
yutingzhao1991,
kiner-tang,
jeasonstudio,
gin-lsl,
Likang0122,
LCJove,
MarioJames,
ONLY-yours and
thinkasany
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 7be40ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #901 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 712 712
Lines 21525 21588 +63
Branches 1216 1225 +9
=========================================
+ Hits 21525 21588 +63 ☔ View full report in Codecov by Sentry. |
MarioJames
reviewed
May 23, 2024
thinkasany
reviewed
May 23, 2024
AmAzing129
force-pushed
the
feat/bitcoin-inscription
branch
from
1aac786
to
657ad61
Compare
kiner-tang
reviewed
May 26, 2024
AmAzing129
force-pushed
the
feat/bitcoin-inscription
branch
from
657ad61
to
2aadc72
Compare
AmAzing129
force-pushed
the
feat/bitcoin-inscription
branch
from
ae0df11
to
670ba33
Compare
thinkasany
reviewed
May 30, 2024
AmAzing129
force-pushed
the
feat/bitcoin-inscription
branch
from
6a77093
to
00ea5fa
Compare
jeasonstudio
approved these changes
May 31, 2024
|
https://preview-901-ant-design-web3.surge.sh/components/bitcoin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Background and solution
问题背景：类似于 NFTCard，提供 OrdinalsCard 用于展示铭文
设计思路：UI 层可以使用 NFTCard，而图片信息需要去获取，也就是类似 getNFTMetadata 的逻辑。不过特殊之处在于：
因此不单独透出组件，而是提供统一的 API 读取铭文信息，开发者可以更加灵活地使用，同时依然可以使用 ant-design-web3 提供的 UI 组件。参见
demos/get-inscriptions.tsx注：官方并不提供统一 Open API ordinals/ord#2672 因此使用 Hiro 的开源 API
🔗 Related issue link
#800