Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TokenSelect and CryptoInput Components #916

Merged
merged 26 commits into from
Jun 18, 2024
Merged

Conversation

MarioJames
Copy link
Collaborator

@MarioJames MarioJames commented May 29, 2024

[中文版模板 / Chinese template]

💡 Background and solution

image

新增代币下拉选择 TokenSelect 组件以及加密输入框 CryptoInput 组件

ChangeSet 晚些提交

🔗 Related issue link

Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 2:54am

Copy link

changeset-bot bot commented May 29, 2024

🦋 Changeset detected

Latest commit: 9191ac8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@ant-design/web3-assets Minor
@ant-design/web3-common Minor
@ant-design/web3 Minor
@ant-design/web3-eth-web3js Patch
@ant-design/web3-ethers-v5 Patch
@ant-design/web3-ethers Patch
@ant-design/web3-solana Patch
@ant-design/web3-wagmi Patch
@example/eth-web3js Patch
@example/ethers-v5 Patch
@example/ethers Patch
@ant-design/web3-bitcoin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

github-actions bot commented May 29, 2024

Preview is ready

@MarioJames MarioJames changed the title feat: refer antdesign select component refactor TokenSelect feat: add TokenSelect and CryptoInput Components May 29, 2024
packages/web3/src/crypto-input/demos/basic.tsx Outdated Show resolved Hide resolved
packages/web3/src/crypto-input/demos/basic.tsx Outdated Show resolved Hide resolved
packages/web3/src/token-select/index.tsx Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5c82102) to head (9191ac8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #916    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          712       716     +4     
  Lines        21629     21940   +311     
  Branches      1225      1255    +30     
==========================================
+ Hits         21629     21940   +311     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


### ChainBrowser

| Property | Description | Type | Default | Version |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Property | Description | Type | Default | Version |
| 属性 | 描述 | 类型 | 默认值 | 版本 |

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这边是不是应该用中文呀,看了是zh-cn.md 呀

@thinkasany
Copy link
Collaborator

单测覆盖还差一点点
image
image

packages/web3/src/crypto-input/demos/basic.tsx Outdated Show resolved Hide resolved
packages/web3/src/crypto-input/index.md Outdated Show resolved Hide resolved
packages/web3/src/crypto-input/index.md Show resolved Hide resolved
packages/web3/src/crypto-input/index.tsx Outdated Show resolved Hide resolved
packages/web3/src/crypto-input/index.tsx Outdated Show resolved Hide resolved
@MarioJames
Copy link
Collaborator Author

CI 挂掉是因为 solana-provider 的单测有一些挂掉了,看下怎么处理 @yutingzhao1991 @gin-lsl

@gin-lsl
Copy link
Collaborator

gin-lsl commented Jun 13, 2024

CI 挂掉是因为 solana-provider 的单测有一些挂掉了,看下怎么处理 @yutingzhao1991 @gin-lsl

没看明白为什么 🫠


### TokenChain

| Property | Description | Type | Default | Version |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Property | Description | Type | Default | Version |
| 属性 | 描述 | 类型 | 默认值 | 版本 |

@Likang0122 Likang0122 merged commit 66aaab4 into main Jun 18, 2024
13 checks passed
@Likang0122 Likang0122 deleted the feature/token branch June 18, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants