Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove useless proxyConnectorName #921

Merged
merged 2 commits into from
May 31, 2024
Merged

Conversation

yutingzhao1991
Copy link
Collaborator

[中文版模板 / Chinese template]

💡 Background and solution

在 MobileWallet 实现中新增的 proxyConnectorName 不是必须的,可以去掉。MobileWallet 基于 WalletConnect 实现的,这个 PR 给 WalletConnect 加了 getWagmiConnector,这样就不需要用名字来找 Connector 了。

🔗 Related issue link

#900

Copy link

vercel bot commented May 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 7:23am

Copy link

changeset-bot bot commented May 31, 2024

🦋 Changeset detected

Latest commit: c57c8f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@ant-design/web3-assets Patch
@ant-design/web3-common Patch
@ant-design/web3-wagmi Patch
@ant-design/web3 Patch
@ant-design/web3-eth-web3js Patch
@ant-design/web3-ethers-v5 Patch
@ant-design/web3-ethers Patch
@ant-design/web3-solana Patch
@example/eth-web3js Patch
@example/ethers-v5 Patch
@example/ethers Patch
@ant-design/web3-bitcoin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

github-actions bot commented May 31, 2024

Preview is ready

Copy link

@yutingzhao1991 You can run the pnpm changeset command locally to generate a changelog. Please refer to the operation precautions. https://web3.ant.design/guide/changelog

@yutingzhao1991 可以在本地运行 pnpm changeset 命令生成 changelog, 操作注意事项参考:https://web3.ant.design/guide/changelog-cn

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8a6d1c7) to head (c57c8f4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #921   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          712       712           
  Lines        21525     21588   +63     
  Branches      1216      1247   +31     
=========================================
+ Hits         21525     21588   +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yutingzhao1991 yutingzhao1991 merged commit 6511134 into main May 31, 2024
12 checks passed
@yutingzhao1991 yutingzhao1991 deleted the fix/walletname branch May 31, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants