-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove useless proxyConnectorName #921
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: c57c8f4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@yutingzhao1991 You can run the @yutingzhao1991 可以在本地运行 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #921 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 712 712
Lines 21525 21588 +63
Branches 1216 1247 +31
=========================================
+ Hits 21525 21588 +63 ☔ View full report in Codecov by Sentry. |
[中文版模板 / Chinese template]
💡 Background and solution
在 MobileWallet 实现中新增的 proxyConnectorName 不是必须的,可以去掉。MobileWallet 基于 WalletConnect 实现的,这个 PR 给 WalletConnect 加了 getWagmiConnector,这样就不需要用名字来找 Connector 了。
🔗 Related issue link
#900