Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: optimize site home page #924

Merged
merged 12 commits into from
Jun 12, 2024
Merged

site: optimize site home page #924

merged 12 commits into from
Jun 12, 2024

Conversation

kiner-tang
Copy link
Member

[中文版模板 / Chinese template]

💡 Background and solution

Design:

修改后

Preview:

image

🔗 Related issue link

Copy link

vercel bot commented Jun 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 6:27am

Copy link

changeset-bot bot commented Jun 1, 2024

⚠️ No Changeset found

Latest commit: 58f3a20

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

github-actions bot commented Jun 1, 2024

Preview is ready

Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (518fd83) to head (58f3a20).
Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #924    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          708       712     +4     
  Lines        21461     21628   +167     
  Branches      1214      1304    +90     
==========================================
+ Hits         21461     21628   +167     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiner-tang kiner-tang changed the title feat: optimize site home page site: optimize site home page Jun 1, 2024
@thinkasany
Copy link
Collaborator

  1. 这个位置看着有点高,就会在选择颜色和模式哪一块出现颜色比较奇怪的感觉。
image
  1. 偶然发现一个bug,方便在这个pr中做么,还是单独拆一个任务

预期:选择暗黑模式再选择颜色应该继续保持在暗黑模式

复现:
step1:选择dark mode;
step2: 选择颜色,会立即切回light mode

image
  1. 感觉有点色差

preview上面的区域好灰,设计稿好像白一点
image

@yutingzhao1991
Copy link
Collaborator

背景颜色好像不太对:

image

移动端适配样式有些问题:

image

@kiner-tang
Copy link
Member Author

背景颜色好像不太对:

image 移动端适配样式有些问题: image

最近有点忙,我周末处理一下

@kiner-tang
Copy link
Member Author

背景颜色好像不太对:

image 移动端适配样式有些问题: image

背景色看起来就是这个应该没问题呀
image

@yutingzhao1991
Copy link
Collaborator

image

这里感觉有个明显的边界,但是设计稿里面应该是渐变过去的

@kiner-tang
Copy link
Member Author

image 这里感觉有个明显的边界,但是设计稿里面应该是渐变过去的
image 咦,这边看起来好像没问题的样子哟

@yutingzhao1991
Copy link
Collaborator

image 这里感觉有个明显的边界,但是设计稿里面应该是渐变过去的

image 咦,这边看起来好像没问题的样子哟

我改了下。改了 theme 那块的渐变,现在可以无缝衔接过去了。但是左下角那个球实现出来怪怪的,暂时去掉了,再和设计师对一下。

@yutingzhao1991
Copy link
Collaborator

@thinkasany 主题切换的问题我处理了一下。

@yutingzhao1991
Copy link
Collaborator

image

渐变的效果和设计师对了一下,改为这样了,这样就不会有一个明显的边界了。

@thinkasany
Copy link
Collaborator

@thinkasany 主题切换的问题我处理了一下。

嗯嗯,现在切换正常了。

@yutingzhao1991 yutingzhao1991 merged commit 1d2fba2 into main Jun 12, 2024
12 checks passed
@yutingzhao1991 yutingzhao1991 deleted the site-opt-index branch June 12, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants