Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat spin tip #1046

Merged
merged 3 commits into from
Mar 9, 2016
Merged

Feat spin tip #1046

merged 3 commits into from
Mar 9, 2016

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Feb 21, 2016

#1041

新开分支,因为我没法 push 到 #1041 上。

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @KgTong and @benjycui to be potential reviewers

@afc163 afc163 mentioned this pull request Feb 21, 2016
@ghost
Copy link

ghost commented Feb 22, 2016

直接放在 ... 上面样式上太不协调了。如果设定了文字,直接代替 ... 如何?

@afc163 因为三个点信息不够,因此需要加一个场景描述,两者不互斥的。
三个点表示在执行中,是一个状态,有时使用上缺乏具体语境,因为一个模块的执行中,可能会有多种场景,如初始化,删除中,更新中,等等,因此增加文案会更明白些,使用上来看,直接加在上面而不是替换更适合。

<span className={`${prefixCls}-dot ${prefixCls}-dot-first`} />
<span className={`${prefixCls}-dot ${prefixCls}-dot-second`} />
<span className={`${prefixCls}-dot ${prefixCls}-dot-third`} />
<div className={`${prefixCls}-dots`}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这层去掉好像也可以?

@benjycui
Copy link
Contributor

benjycui commented Mar 9, 2016

CI 不稳定,本地测试正常,合了。

benjycui added a commit that referenced this pull request Mar 9, 2016
@benjycui benjycui merged commit 899f1e4 into develop-1.0.0 Mar 9, 2016
@benjycui benjycui deleted the feat-spin-tip branch March 9, 2016 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants