Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve layout #1082

Merged
merged 7 commits into from
Mar 9, 2016
Merged

Improve layout #1082

merged 7 commits into from
Mar 9, 2016

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Feb 25, 2016

  1. 增加了响应式布局。
  2. 增加了 gutter 参数用于栅格间隔。
    Layout布局不支持响应式 #494 layout api 参考 #871

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @pizn to be a potential reviewer

@afc163
Copy link
Member Author

afc163 commented Mar 7, 2016

一个比较方便兼容原有 API 的响应式 API 方式:

<Row>
  <Col md={{ span: 8, offset: 1, pull: 1 }} lg={{ span: 12, offset: 1, pull: 1 }}></Col>
  <Col md={{ span: 16, offset: 1, pull: 1 }} lg={{ span: 12, offset: 1, pull: 1 }}></Col>
</Row>

@afc163 afc163 removed the In progress label Mar 7, 2016
@afc163 afc163 mentioned this pull request Mar 8, 2016
21 tasks

ReactDOM.render(
<Row>
<Col xs={0} sm={4} md={6} lg={8} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xs={0} 的时候好像有点问题

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看了下其他栅格实现,都没有对 0 的处理,例子我改掉。

benjycui added a commit that referenced this pull request Mar 9, 2016
@benjycui benjycui merged commit c79e2dc into develop-1.0.0 Mar 9, 2016
@benjycui benjycui deleted the improve-layout branch March 9, 2016 10:02
@benjycui
Copy link
Contributor

做了点修改 268fac6

@pizn
Copy link
Contributor

pizn commented Mar 10, 2016

👍

@czn574775237
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants