Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tree/index.d.ts seems incorrect. "AntTreeNodeProps" has invalid "icon" property type. #10840

Closed
1 task done
Voronar opened this issue Jun 7, 2018 · 1 comment · Fixed by Voronar/ant-design#1 or #10841
Closed
1 task done

tree/index.d.ts seems incorrect. "AntTreeNodeProps" has invalid "icon" property type. #10840

Voronar opened this issue Jun 7, 2018 · 1 comment · Fixed by Voronar/ant-design#1 or #10841

Comments

@Voronar
Copy link
Contributor

Voronar commented Jun 7, 2018 •
edited

  • I have searched the issues of this repository and believe that this is not a duplicate.

Version

3.6.1

Environment

OSX, Chrome

Reproduction link

Edit on CodeSandbox

Steps to reproduce

Try to pass React.ReactNode type property in to TreeNode component icon property.

What is expected?

You should be able to pass React.ReactNode type property in to TreeNode component icon property.

What is actually happening?

AntTreeNodeProps type contains incorrect icon property type.
@Voronar Voronar mentioned this issue Jun 7, 2018
Merged
10 tasks
@Voronar Voronar mentioned this issue Jun 7, 2018
Merged
10 tasks
@Voronar
Copy link
Contributor Author

Voronar commented Jun 7, 2018

Sorry for tangled issue list. It is my first pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #10838 Voronar/ant-design
Fix #10840 Voronar/ant-design
1 participant
@Voronar