Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Col xl and xxl are missing padding from gutter variable. #11003

Closed
1 task done
MiroslavPetrik opened this issue Jun 22, 2018 · 4 comments
Closed
1 task done

Col xl and xxl are missing padding from gutter variable. #11003

MiroslavPetrik opened this issue Jun 22, 2018 · 4 comments
Assignees
Labels

Comments

@MiroslavPetrik
Copy link

  • I have searched the issues of this repository and believe that this is not a duplicate.

Version

3.6.3

Environment

Chromium Version 66.0.3359.181 (Official Build) Built on Ubuntu , running on Ubuntu 16.04 (64-bit)

Reproduction link

https://ant.design/components/grid/

Steps to reproduce

  1. Override the default @grid-gutter-width variable to custom value.
@import 'antd/dist/antd.less';
@grid-gutter-width: 30px;
  1. Render
<Row>
   <Col xl={12}>
      Missing
   </Col>
   <Col xl={12}>
      Padding
   </Col>
</Row>

What is expected?

The class ant-col-xl-12 applied to Col component should have padding equal to @grid-gutter-width/2.

What is actually happening?

The xl-* and xxl-* classes are padding-less - the gutter variable is not tied to them...


I believe xl and xxl prefixes are missing here...
Grid Component style source

@afc163
Copy link
Member

afc163 commented Jun 22, 2018

<Row gutter={30}>
   <Col xl={12}>
      Missing
   </Col>
   <Col xl={12}>
      Padding
   </Col>
</Row>

@afc163 afc163 closed this as completed Jun 22, 2018
@MiroslavPetrik
Copy link
Author

@afc163 thats a quick fix, but the issue still exists and you just ignored it. I don't want to pollute the JSX with explicit gutter everywhere.

@afc163 afc163 reopened this Jun 24, 2018
@ghost
Copy link

ghost commented Jul 4, 2018

Hello, I've just come across the same issue.

@afc163
Copy link
Member

afc163 commented Mar 6, 2019

I will reopen this if you guys provide a reproducible github repository.

@afc163 afc163 closed this as completed Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants