feat(checkbox group): checkbox group support disable specified item. #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const optionsWithDisabled = [ | ||
| { label: '苹果', value: 'Apple' }, | ||
| { label: '梨', value: 'Pear' }, | ||
| { label: '橙子', value: 'Orange', disabled: false }, |
There was a problem hiding this comment.
这个例子同时使用了子项和整个 Group 的 disabled 特性。整个 Group disabled, 某个 enabled
hotoo
force-pushed
the
group-checkbox-disabled
branch
from
81d8299
to
a915fca
Compare
| {option.label} | ||
| </Checkbox> | ||
| options.map(option => { | ||
| const disabled = Object.hasOwnProperty.call(option, 'disabled') ? option.disabled : this.props.disabled; |
There was a problem hiding this comment.
此处可以简单的用 'disabled' in option 来判断。
There was a problem hiding this comment.
不能，disabled 是特殊属性，会抛出异常。
There was a problem hiding this comment.
哦，想起来了，昨天是基于 master 改的，option 是字符串的时候会抛出异常。
hotoo
force-pushed
the
group-checkbox-disabled
branch
from
a915fca
to
e0172ca
Compare
|
好了，再看看。 |
afc163
added a commit
that referenced
this pull request
Mar 17, 2016
feat(checkbox group): checkbox group support disable specified item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for your contribution! :-)
Please makes sure these boxes are checked before submitting your PR, thank you!
[x] Run
npm run lintand fix those errors before submitting in order to keep consistent code style.[x] Rebase before creating a PR to keep commit history clear.
[x] Add some descriptions and refer relative issues for you PR.
支持在 Checkbox Group 的子项中指定 disabled 属性。