Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preventDefault for onClose. #1267

Merged
merged 2 commits into from
Mar 27, 2016
Merged

Conversation

i-tengfei
Copy link

First of all, thanks for your contribution! :-)

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @afc163, @benjycui and @jljsj33 to be potential reviewers

@afc163
Copy link
Member

afc163 commented Mar 25, 2016

lint 没过啊。

@afc163
Copy link
Member

afc163 commented Mar 27, 2016

Run npm run lint and fix those errors before submitting in order to keep consistent code style.

@i-tengfei
Copy link
Author

Sorry,业务需要随手在页面上改了一下,没注意到,已修改 :)

@afc163 afc163 merged commit 5ecd21a into ant-design:develop-1.0.0 Mar 27, 2016
@afc163 afc163 mentioned this pull request Aug 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants