Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expandedRow hover style should built in Nested tables #12877

Closed
ycjcl868 opened this issue Oct 30, 2018 · 7 comments
Closed

expandedRow hover style should built in Nested tables #12877

ycjcl868 opened this issue Oct 30, 2018 · 7 comments
Assignees

Comments

@ycjcl868
Copy link
Contributor

ycjcl868 commented Oct 30, 2018

Description

If I don't add the .components-table-demo-nested .ant-table-expanded-row:hover > td { background: #fbfbfb; } in my project, I might think expanded row is a bug when hovered.

Screenshot

image

Reproduce

https://codesandbox.io/s/x972o75k1p

Expection

image

@zombieJ
Copy link
Member

zombieJ commented Oct 31, 2018

expandedRowRender 支持 hover 加上 Table 本身背景是没有颜色的,联合起来效果的确挺诡异的。但是这个更偏使用场景,不能算是 antd 的问题。让用户给内嵌的 table 加 class 吧

@ycjcl868
Copy link
Contributor Author

感觉可以在官网例子注明下,很多用户 会误以为是 bug

@afc163
Copy link
Member

afc163 commented Oct 31, 2018

可以给内嵌 Table 加上背景色。

@zombieJ
Copy link
Member

zombieJ commented Oct 31, 2018

要加顺便给 Header 也搞个颜色吧,否则也不好看:https://codesandbox.io/s/n3yvkllzzp

2018-10-31 4 02 59

@afc163 afc163 self-assigned this Nov 2, 2018
@afc163 afc163 closed this as completed in 2aefdda Nov 2, 2018
@yp
Copy link
Contributor

yp commented Nov 7, 2018

I have an issue introduced by commit 2aefdda.
I have a table inside a card which is shown in the expandedRowRenderer of another table. Everything was fine in 3.10.3, but with 3.10.4 (which introduced the negative margins), the inner table expands outside the card body. Do you really think that having such margins by default is a good choice?

@afc163
Copy link
Member

afc163 commented Nov 8, 2018

@yp Can you describe your problem in a new issue with reproducible demo?

@afc163
Copy link
Member

afc163 commented Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants