Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Component Image #13719

Closed
ycjcl868 opened this issue Dec 19, 2018 · 17 comments
Closed

New Component Image #13719

ycjcl868 opened this issue Dec 19, 2018 · 17 comments

Comments

@ycjcl868
Copy link
Contributor

ycjcl868 commented Dec 19, 2018

<Image src={src} />
// click image to zoom in / zoom out / rotate
<Image zoom  src={src} />
// image clip
<Image clip={{ obj }} src={src} />
// banner image load image 1x before image 2x ready
<Image image1x={1x} image2x={2x}  src={src} onLoad={() => {}} />
// loading (1-100)
<Image loading={50} src={src} />

zoom in out Inspired by react-zmage:

image

in addition, Image can controll gif , like zhihu:

image

https://github.com/KyleAMathews/react-retina-image

@afc163
Copy link
Member

afc163 commented Dec 19, 2018

https://www.npmjs.com/package/react-image
https://jossmac.github.io/react-images/
https://github.com/sergiodxa/react-lazy-image
https://github.com/Caldis/react-zmage

<Image
  caption=""
  description=""
  srcset="elva-fairy-320w.jpg 320w"
  lazy={{ offset: 100 }}
  placeholder
/>

@orzyyyy
Copy link
Contributor

orzyyyy commented Dec 19, 2018

What about PicturesWall like this.

I don't think it's a good idea that Upload does too much thing that is not its matter.

@ycjcl868
Copy link
Contributor Author

ycjcl868 commented Dec 19, 2018

@zy410419243 yeah, Pictures Wall in Upload should be replace by Image component.

@ilanus
Copy link
Contributor

ilanus commented Dec 19, 2018

@ycjcl868 I agree, very good idea

@ztplz
Copy link
Contributor

ztplz commented Dec 19, 2018

Sounds good. Any plan about API?

@ztplz
Copy link
Contributor

ztplz commented Dec 19, 2018

@afc163 我加个hook form?

@afc163
Copy link
Member

afc163 commented Dec 20, 2018

@ztplz Seems not related to this issue.

@orzyyyy
Copy link
Contributor

orzyyyy commented Jan 27, 2019

Is there any progress?

@ycjcl868
Copy link
Contributor Author

ycjcl868 commented Jan 27, 2019

WIP in react-component/image

@afc163
Copy link
Member

afc163 commented Jan 28, 2019

https://photoswipe.com

@dmdoit
Copy link

dmdoit commented Apr 23, 2019

这个组件真的挺需要的

@ycjcl868
Copy link
Contributor Author

@dmdoit 有哪些需求?收集下加进去

@afc163
Copy link
Member

afc163 commented May 8, 2019

image checkbox

070739_A2EZ_2720166

#16442

@and80506
Copy link

很早就开始关注和使用antd,去年开始我们基于antd现有组件及规范,针对内部toB业务维护了一套自己的设计规范和组件库,有相应的图片查看组件,可评估下是否满足社区需求,看下反哺社区是否有可能。
https://nsfi.github.io/ppfish-components/#/components/picturePreview
image

@afc163
Copy link
Member

afc163 commented Aug 6, 2020

@crazyair
Copy link
Member

crazyair commented Sep 9, 2020

缺少鼠标滚动变大缩小、推动图片会自动回到中心位置,无法固定。

@afc163 afc163 closed this as completed Nov 2, 2020
@zlab
Copy link

zlab commented Nov 15, 2020

怎么没有上一张,下一张的功能

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants