New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve Empty component #15444
Conversation
Deploy preview for ant-design ready! Built with commit 77370c4 |
Deploy preview for ant-design ready! Built with commit 6257fe3 |
Deploy preview for ant-design ready! Built with commit da7b25c |
|
Codecov Report
@@ Coverage Diff @@
## feature #15444 +/- ##
===========================================
+ Coverage 94.1% 94.11% +<.01%
===========================================
Files 250 250
Lines 6635 6643 +8
Branches 1938 1943 +5
===========================================
+ Hits 6244 6252 +8
Misses 390 390
Partials 1 1
Continue to review full report at Codecov.
|
components/empty/demo/customize.md
Outdated
|
||
## en-US | ||
|
||
Customize image, description and extra content. | ||
Customize image source,image size, description and extra content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- source,image size
+ source, image size
absence of a space
抱歉看到的有点晚,感觉这些可不可以合到
|
这个还是推荐这样的语法会比较好: |
或者 <Empty image={Empty.PRESETTED_IMAGE} /> |
👍 可以的 @DiamondYuan ,意下如何? |
我觉得这样好。等有空了提交一下。 |
那么是 还是 |
这种? |
可以 |
PRESENTED_IMAGE_DEFAULT PRESENTED_IMAGE_SIMPLE |
转移阵地 Transfer position |
🤔 This is a ...
👻 What's the background?
#15442
💡 Solution
How to fix the problem, and list final API implementation and usage sample if that is an new feature.
GIF or snapshot should be provided if includes UI/interactive modification.
📝 Changelog description
empty component support imageSize prop
empty 组件支持设定图片尺寸
☑️ Self Check before Merge