Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inline Menu inside Layout Sider still flash and shake when collapsed #15797

Closed
1 task done
panjiesw opened this issue Apr 1, 2019 · 8 comments · Fixed by #15868
Closed
1 task done

inline Menu inside Layout Sider still flash and shake when collapsed #15797

panjiesw opened this issue Apr 1, 2019 · 8 comments · Fixed by #15868
Labels
🐛 Bug Ant Design Team had proved that this is a bug.

Comments

@panjiesw
Copy link
Contributor

panjiesw commented Apr 1, 2019

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

Click the menu Icon left side of the Header

What is expected?

menu inside Layout Sider collapsed with no flash

What is actually happening?

menu inside Layout Sider collapsed with flash

Environment Info
antd 3.16.1
React 16.8.6
System Manjaro 18
Browser FireFox Developer Edition 67.0b3 (64-bit)

This is related to #15614. I believe this has been fixed in v3.16.0 with #15625. While it's no longer flashing and shaking if Menu is NOT inside a Layout Sider, it's still so when used inside Sider.
@keithort
Copy link

keithort commented Apr 1, 2019

I see this on Chrome 73 on Win10 as well.

@afc163
Copy link
Member

afc163 commented Apr 2, 2019

@zy410419243

@orzyyyy
Copy link
Contributor

orzyyyy commented Apr 2, 2019

I'm sorry for this bug, but I must focus on my own work this month.

@afc163 afc163 added the 🐛 Bug Ant Design Team had proved that this is a bug. label Apr 2, 2019
@afc163 afc163 mentioned this issue Apr 2, 2019
Closed
8 tasks
@fluxxx020
Copy link

I also saw this Bug!

@zombieJ zombieJ mentioned this issue Apr 5, 2019
Merged
13 tasks
@afc163
Copy link
Member

afc163 commented Apr 5, 2019

Fixed in #15868

@afc163 afc163 closed this as completed Apr 5, 2019
@Shlok-Zanwar
Copy link

@afc163 It still does flicker for me !
What's the fix ?

@fedormoore
Copy link

problem still exists

@Shlok-Zanwar
Copy link

Shlok-Zanwar commented Oct 3, 2022 via email •
edited

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug Ant Design Team had proved that this is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Refactor Menu related components life cycle methods ant-design/ant-design
8 participants
@afc163 @yutingzhao1991 @panjiesw @keithort @fedormoore @orzyyyy @fluxxx020 @Shlok-Zanwar