Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a "size" property to the Tag API #18745

Closed
1 task done
dylanavery720 opened this issue Sep 9, 2019 · 3 comments
Closed
1 task done

Add a "size" property to the Tag API #18745

dylanavery720 opened this issue Sep 9, 2019 · 3 comments
Assignees
@afc163

Comments

@dylanavery720
Copy link

dylanavery720 commented Sep 9, 2019 •
edited

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

Allows Tag to be used more dynamically inside of table rows, or description lists for instance. Allows Tag to behave more like Button, or other components which have a size property.

What does the proposed API look like?

"size - "can be set to small large or omitted" / string / default

Small tag would fit in small table row.
@dylanavery720 dylanavery720 changed the title Add a "size" property" to the Tag API Add a "size" property to the Tag API Sep 9, 2019
@yoyo837 yoyo837 added Component: Tag help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. labels Sep 10, 2019
@afc163
Copy link
Member

afc163 commented Sep 10, 2019

There is no size for Tag in design.

@yoyo837 yoyo837 removed the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Sep 10, 2019
@ant-design ant-design deleted a comment from ant-design-bot Sep 10, 2019
@dylanavery720
Copy link
Author

There is no size for Tag in design.

Can I add this property to the API then? I can make a pull request.

@afc163
Copy link
Member

afc163 commented Sep 11, 2019

In our design specificity, we don't provider differece size of Tags. You can customize your own Tag component based on our Tag.

@afc163 afc163 closed this as completed Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afc163 afc163

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@afc163 @yoyo837 @dylanavery720