Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefixIcon in input-group has a hardcoded style that breaks less theme #18788

Closed
1 task done
wzhudev opened this issue Sep 12, 2019 · 2 comments
Closed
1 task done

prefixIcon in input-group has a hardcoded style that breaks less theme #18788

wzhudev opened this issue Sep 12, 2019 · 2 comments
Assignees
@zombieJ
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@wzhudev
Copy link
Contributor

wzhudev commented Sep 12, 2019 •
edited

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

The color could be themable. Now it's hard coded with (style). Ref NG-ZORRO/ng-zorro-antd#3950 (comment).

What does the proposed API look like?

No API required. Just need to use or possibly add a less variable.
@wzhudev wzhudev changed the title prefixIcon in nz-input-group has a hardcoded style that brakes scss theme prefixIcon in input-group has a hardcoded style that brakes scss theme Sep 12, 2019
@wzhudev wzhudev changed the title prefixIcon in input-group has a hardcoded style that brakes scss theme prefixIcon in input-group has a hardcoded style that breaks less theme Sep 12, 2019
@wzhudev
Copy link
Contributor Author

wzhudev commented Sep 12, 2019

If you guys would like a change I can open a PR for this.

@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Sep 13, 2019
@ant-design-bot
Copy link
Contributor

Hello @wendzhue. We totally like your proposal/feedback, welcome to send us Pull Request for it. Please send your Pull Request to proper branch (feature branch for new feature, master for bugfix and other changes), fill the [Pull Request Template] here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forword to your contribution!

你好 @wendzhue, 我们完全同意你的提议/反馈，欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支（新特性发到 feature 分支，其他发到 master 分支），务必填写 Pull Request 内的预设模板，提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等，并确保 CI 通过，我们会尽快进行 Review，提前感谢和期待您的贡献！

giphy

@wzhudev wzhudev closed this as completed Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zombieJ zombieJ

Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@afc163 @zombieJ @wzhudev @ant-design-bot