feature for breadcrumb

[plandem]

add method to get title for route instead of using breadcrumbName.

Now it's using this code(Breadcrumb.js) to get title:

          if (!route.breadcrumbName) {
            return null;
          }
          var name = route.breadcrumbName.replace(/:(.*)/g, function (replacement, key) {
            return params[key] || replacement;
          });

What i need:

var name = this.titleRender(route, params);

where default titleRender is :

Breadcrumb.defaultProps = {
  titleRender: function titleRender(route, params) {
 if (!route.breadcrumbName) {
            return null;
          }

          var name = route.breadcrumbName.replace(/:(.*)/g, function (replacement, key) {
            return params[key] || replacement;
          });
  }  
}

Why do i need it?

1. i'm using https://github.com/callum/redux-routing , but not react-router and i don't want to 'patch' routes to set breadcrumbName

2. i need custom logic - for first item, i want to draw icon, for rest i want text, now i do it like this:

                    <Breadcrumb>
                        { path.map((route, i) => {
                            let title = (i === 0) ? <Icon type="home"/> : formatMessage(messages[route.path]);
                            return (i !== last_i)
                                ? <Breadcrumb.Item key={i} href={'#' + route.build(route.path, matched.params)}>{title}</Breadcrumb.Item>
                                : <Breadcrumb.Item key={i}>{title}</Breadcrumb.Item>
                        }) }
                    </Breadcrumb>

In that case i would replace it with:

<Breadcrumb routes={routes} titleRender={(route, params) => { 
if (route.path === 'index') 
   return <Icon type="home"/>
else 
   return formatMessage(messages[route.path]);
}
}>

[plandem]

i can make a pull request, if you want

[afc163]

I like it, you can pr for that, and please keep downward compatibility of breadcrumbName.

[plandem]

i will move current behaviour to default implementation for titleRender, so it will be backward compatible

[plandem]

now it can be used like this:

<Breadcrumb routes={path} params={matched.params} nameFormatter={(route, params)=> {
    if(route.path === ROUTE_TYPE.index) {
        return <Icon type="home"/>
    } else {
        return formatMessage(messages[route.path]);
    }
}}/>

[lock]

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.