Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination component and 3.X version behave inconsistently —— pagination组件和3.X版本的表现不一致 #20529

Closed
1 task done
thding opened this issue Dec 30, 2019 · 0 comments
Assignees

Comments

@thding
Copy link
Contributor

thding commented Dec 30, 2019

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

Open the link and add the pagination property to the Table component. The property value is {total: null}. Pagination cannot be used in 4.X version. After changing the version of antd to 3.X, the pagination component can be used normally —— 打开链接,在Table组件中添加pagination属性,属性值为{total:null},在4.X版本pagination无法使用。将antd的版本改为3.X后,pagination组件可以正常使用

What is expected?

Consistent with version 3.X —— 和3.X版本行为保持一致

What is actually happening?

pagination component is not working —— pagination组件无法使用

Environment Info
antd 4.0.0-beta.1
React 16.12.0
System macOS Catalina 10.15.2
Browser Chrome 81.0.4011.0 canary (64)

Is this an intentional change? Make the null value of the total attribute behave correctly? However, I personally think this is a break change. In the original 3.X version, the boundary treatment of null values should be retained —— 这是有意的改动吗?使得total属性的null值得到正确的表现?但是个人觉得这是个break change,在原有的3.X版本中对null值进行的边界处理我觉得应该保留

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants