Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use Tooltip with Step #20957

Open
1 task done
uturnr opened this issue Jan 17, 2020 · 5 comments
Open
1 task done

Can't use Tooltip with Step #20957

uturnr opened this issue Jan 17, 2020 · 5 comments
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. improvement improve some features Inactive

Comments

@uturnr
Copy link

uturnr commented Jan 17, 2020

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

Unless using progressDot style which has a function that allows to override the dot component, a Step (Steps.Step) cannot be wrapped in a Tooltip.

What is expected?

Wrapping a Step in a Tooltip causes a tooltip to appear on hover.

What is actually happening?

Wrapping a Step in a Tooltip causes the Step to disappear.

Environment Info
antd 3.26.7
React 16.12.0
System macOS 10.15.2
Browser Safari 13.0.4
@zombieJ
Copy link
Member

zombieJ commented Jan 17, 2020

Current Steps will loop children to add additional prop. Maybe should refactor with context instead.

@zombieJ zombieJ added the improvement improve some features label Jan 17, 2020
@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Jul 1, 2020
@ant-design-bot
Copy link
Contributor

Hello @uturnr. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @uturnr, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!

giphy

@oaksharks
Copy link

Is there any progress in this issue? I want to use Tooltip with Step too

@sangeetha-armtek
Copy link

Does anybody know a work around for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. improvement improve some features Inactive
Projects
None yet
Development

No branches or pull requests

7 participants