Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onExpandedRowsChange return not correctly when rowKey is set #21504

Closed
chiaweilee opened this issue Feb 21, 2020 · 3 comments
Closed

onExpandedRowsChange return not correctly when rowKey is set #21504

chiaweilee opened this issue Feb 21, 2020 · 3 comments
Labels
3.x 3.x stable issue or bug fix, PR should be cherry-pick to master 🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive

Comments

@chiaweilee
Copy link
Contributor

chiaweilee commented Feb 21, 2020

  • [ x ] I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Table

Steps to reproduce

1, set rowKey
2, bind expandedRowKeys to state
3, get expandedRowKeys from onExpandedRowsChange
4, load dataSource and set new expandedRowKeys state

What is expected?

onExpandedRowsChange not trigger / return fresh expandedRows

What is actually happening?

onExpandedRowsChange return []

Environment Info
antd 3.26.11
React 16.12.0
System Mac OS
Browser Chrome

20200221114722

@zombieJ
Copy link
Member

zombieJ commented Feb 22, 2020

Hmm... I agree onExpandedRowsChange should not trigger.

@zombieJ zombieJ added 3.x 3.x stable issue or bug fix, PR should be cherry-pick to master 🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. labels Feb 22, 2020
@ant-design-bot
Copy link
Contributor

Hello @chiaweilee. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @chiaweilee, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!

giphy

@chiaweilee
Copy link
Contributor Author

image

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x 3.x stable issue or bug fix, PR should be cherry-pick to master 🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive
Projects
None yet
Development

No branches or pull requests

3 participants