Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal.info等静态方法支持通过config方法指定渲染容器 #23384

Closed
1 task
zetay opened this issue Apr 19, 2020 · 2 comments
Closed
1 task

Modal.info等静态方法支持通过config方法指定渲染容器 #23384

zetay opened this issue Apr 19, 2020 · 2 comments
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive

Comments

@zetay
Copy link

zetay commented Apr 19, 2020

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

在ShadowDOM中使用Modal.info等静态方法时可以将DOM渲染到ShadowRoot中

What does the proposed API look like?

参照Notification或者message,提供config方法,可以指定getContainer。或者可以接收ConfigProvider传入的getPopupContainer

@zetay zetay changed the title Modal.info等静态方法支持config.getContainer方法 Modal.info等静态方法支持指定渲染容器 Apr 19, 2020
@afc163

This comment has been minimized.

@afc163 afc163 marked this as a duplicate of #23085 Apr 19, 2020
@afc163 afc163 closed this as completed Apr 19, 2020
@zetay zetay changed the title Modal.info等静态方法支持指定渲染容器 Modal.info等静态方法支持通过config方法指定渲染容器 Apr 19, 2020
@afc163 afc163 reopened this Aug 26, 2020
@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Aug 26, 2020
@ant-design-bot
Copy link
Contributor

Hello @zetay. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @zetay, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!

giphy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive
Projects
None yet
Development

No branches or pull requests

3 participants