Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Menu] 建议提供关闭 scrollIntoView 功能的 prop #23936

Closed
1 task done
oustn opened this issue May 7, 2020 · 2 comments · Fixed by #24223
Closed
1 task done

[Menu] 建议提供关闭 scrollIntoView 功能的 prop #23936

oustn opened this issue May 7, 2020 · 2 comments · Fixed by #24223
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@oustn
Copy link

oustn commented May 7, 2020

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

当菜单出现滚动条且页面缩放(scale)的时候,由于容器组件的尺寸计算使用的是 clientHeight,导致位置计算错误,scrollIntoView 的节点错误。

Demo

鼠标移动到 Option3 时可见现象,导致滚动位置错误。

What does the proposed API look like?

Menu 上提供一个 prop, 可以关闭这个功能

@afc163
Copy link
Member

afc163 commented May 8, 2020

可以直接去掉这个功能,给 https://github.com/react-component/menu 来个 PR 吧。

@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label May 8, 2020
@ant-design-bot
Copy link
Contributor

Hello @oustn. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @oustn, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!

giphy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants