Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inline styling from ant components (props) #23942

Open
1 task done
jarekmarciniak opened this issue May 7, 2020 · 3 comments
Open
1 task done

Remove inline styling from ant components (props) #23942

jarekmarciniak opened this issue May 7, 2020 · 3 comments
Labels
improvement improve some features Inactive

Comments

@jarekmarciniak
Copy link

jarekmarciniak commented May 7, 2020

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

Right now some components like aside navigation etc. have some of the styles by default in html structure, and some of them in css files. It makes the whole styling process way more complicated then it should be, and forces a front-end developer to split their work in two (by using css and props).

What does the proposed API look like?

Everything that relates to styling should be moved to CSS for easier and more consistent work. Elements like aside should not contain any inline styles when rendered and should get all styling from .css file/s.

@yoyo837 yoyo837 added the improvement improve some features label May 8, 2020
@afc163
Copy link
Member

afc163 commented Aug 3, 2020

Elements like aside should not contain any inline styles

Could you point exactly what the inline styles are?

@07akioni
Copy link
Contributor

07akioni commented Aug 3, 2020

Elements like aside should not contain any inline styles

Could you point exactly what the inline styles are?

Seems width or something related...

@hanomain99
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement improve some features Inactive
Projects
None yet
Development

No branches or pull requests

6 participants