New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Card activeTabKey or tabActiveKey #24208
Comments
我觉得改了会造成 breaking change 的... |
如果要改肯定要兼容,然后加 warning。 |
Can it be simplified to |
In my see, Card had many tab props, we can remove it(waring), and use it <Card
tabProps={{
activeKey: 1,
defaultActiveKey: 1
}}
</> |
tab前缀的属性在Card tab相关功能中有明确指向性意图是tab相关功能使用的。个人建议保留。 |
没有特别的倾向性,感觉两者都差不多。原本的把 PS: 定完了可以更新一下:https://github.com/ant-design/ant-design/wiki/API-Naming-rules |
按照 naming standard,属性名都要先过一下已有的名称表。个人感觉 pro layout 才是 typo = = |
这种属于 compose 组件,心智上来说我觉得都放到 |
个人觉得不管是什么 最好是一种统一的风格,对于我这种有些强迫症的人来说,就好比 文档中的有的默认值用‘ 包裹 有的没有,我一直都想把所有的给他统一😭 |
Are
tabActiveKey
anddefaultTabActiveKey
better prop name?In pro-layout it named to
tabActiveKey
.The text was updated successfully, but these errors were encountered: