New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change react-sticky dependency (contains deprecated code) #24775
Comments
Hello @albertms10. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution! 你好 @albertms10, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献! |
@bralemili @albertms10 Could you help to update demo? |
In our case we're using one div to fix at the top using affix and we're using react-stickynode to stack the tab header to div sticky component when scrolled. with react-stickynode the Tab bar is adding extra padding at the bottom as well and we're uanble to make it work, @afc163 or @bralemili do you have any solutions for this? https://codesandbox.io/s/modest-mendeleev-c7i3hz?file=/src/App.js |
What problem does this feature solve?
When using
react-sticky
’s components, a warning is thrown with the following message:Knowing the component hasn’t been updated in 2 years, it may be a good decision to move forward and use another similar package.
What does the proposed API look like?
A similar dependency that has been updated is
react-stickynode
and works similarly, without any warning.However, if a
Tabs
component is placed inside it, it won’t show its ink bar (as happened in Ant Design v4.3.0 withreact-sticky
).If you try to replace it with the native
Affix
component, it behaves the same (no ink bar).Please, consider updating the
Sticky
-related dependency or just fix theTab
usage inside anAffix
component (to achieve the same result natively).The text was updated successfully, but these errors were encountered: