Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Statistic.Countdown] Would be nice to have a pause/start api. #26182

Open
1 task done
EggTronic opened this issue Aug 13, 2020 · 3 comments
Open
1 task done

[Statistic.Countdown] Would be nice to have a pause/start api. #26182

EggTronic opened this issue Aug 13, 2020 · 3 comments
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive

Comments

@EggTronic
Copy link

EggTronic commented Aug 13, 2020

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

In some cases, countdown might need to be paused and continue later on.

What does the proposed API look like?

const { Countdown } = Statistic;
const deadline = 1000 * 30; // mili seconds, not depend on Data.now()
const ref= useRef(null);
const autoStart = false; // boolean

// once mounted, we can call following API to control the countdown
ref.start()
ref.pause()

Countdown: ref={ref} autoStart={autoStart} value={deadline} onFinish={onFinish}

@EggTronic
Copy link
Author

The lib called 'react-compound-timer' may give you some idea.

@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Aug 14, 2020
@ant-design-bot
Copy link
Contributor

Hello @EggTronic. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @EggTronic, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!

giphy

@Junaid300
Copy link

Junaid300 commented Sep 28, 2022

is pause functionality added in Statistic.Coundown?

context: Object
refs: Object
updater: Object
syncTimer: ƒ () {}
startTimer: ƒ () {}
stopTimer: ƒ () {}
formatCountdown: ƒ () {}
valueRender: ƒ () {}
_reactInternals: FiberNode
_reactInternalInstance: Object
state: null
countdownId: undefined
isReactComponent: Object
setState: ƒ () {}
forceUpdate: ƒ () {}

How can we pause the time? stop and start timer api is available but pause api is not available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants