Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputNumber incorrect step behavior #26285

Open
1 task done
leanniby opened this issue Aug 19, 2020 · 9 comments
Open
1 task done

InputNumber incorrect step behavior #26285

leanniby opened this issue Aug 19, 2020 · 9 comments
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive

Comments

@leanniby
Copy link

leanniby commented Aug 19, 2020

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

  • Focus input element
  • Enter any number (example "1")
  • No changing focus, click up step button

What is expected?

Increment value after click step button ("2", "3" ...)

What is actually happening?

Show value is changed "2", "1", "1", "2", "1", "1",...

Environment Info
antd 4.5.4
React 16.12
System any
Browser any

The current behavior is reproduced when used redux and redux-saga

@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Aug 19, 2020
@ant-design-bot
Copy link
Contributor

Hello @leanniby. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @leanniby, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!

giphy

@netochaves
Copy link

Hi guys, I would like to work on this if that's ok

@xrkffgg
Copy link
Member

xrkffgg commented Aug 24, 2020

PR welcome~

@prasanthLalapeta
Copy link

Any updates on this issue ?

@xrkffgg xrkffgg added the 🤔 Need Reproduce We cannot reproduce your problem label Oct 28, 2020
@ant-design-bot
Copy link
Contributor

Hello @leanniby. Please provide a online reproduction by forking this link https://u.ant.design/codesandbox-repro or a minimal GitHub repository. Issues labeled by Need Reproduce will be closed if no activities in 7 days.

你好 @leanniby, 我们需要你提供一个在线的重现实例以便于我们帮你排查问题。你可以通过点击 此处 创建一个 codesandbox 或者提供一个最小化的 GitHub 仓库。7 天内未跟进的 issue 将会被自动关闭。

@headwindz
Copy link
Contributor

@xrkffgg It can be consistently reproduced in the code sample @leanniby provides. I took a quick look and It's related to the setValue is called in asynchronous way (i.e inside a setTimeout)

@xrkffgg
Copy link
Member

xrkffgg commented Oct 29, 2020

@xrkffgg It can be consistently reproduced in the code sample @leanniby provides. I took a quick look and It's related to the setValue is called in asynchronous way (i.e inside a setTimeout)

PR welcome ~

@chiptoe
Copy link

chiptoe commented Nov 4, 2020

@netochaves any updates?

@ant-design-bot
Copy link
Contributor

This issue is closed because it has been marked as Need Reproduce, but has not had recent activity.
If you can provide a reproduce, feel free to ping anyone of our maintainers to reopen this issue.
Thank you for your contributions.

@afc163 afc163 removed the 🤔 Need Reproduce We cannot reproduce your problem label Nov 13, 2020
@afc163 afc163 reopened this Nov 13, 2020
@afc163 afc163 changed the title NumberInput incorrect step behavior InputNumber incorrect step behavior Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive
Projects
None yet
Development

No branches or pull requests

8 participants