Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RangePicker] Missing hoverRange border in year panel when start date and end date are in the same year #27855

Closed
1 task done
AlanCutFlim opened this issue Nov 18, 2020 · 4 comments
Labels
🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive 💄 style less css

Comments

@AlanCutFlim
Copy link
Contributor

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

https://ant.design/components/date-picker-cn/#components-date-picker-demo-range-picker

Steps to reproduce

  • Enter the link and find the date type RangePicker
  • Select a start date and end date in year 2020
  • Then click the end date in input and enter the year pannel in the right side
  • Hover next year in the year panel
  • If you can't reproduce it, please follow the steps in the GIF below
    bug233

What is expected?

There is border

What is actually happening?

There is no border
image

Environment Info
antd 4.8.4
React react 16.14.0
System macOS Catalina 10.15.4
Browser Chrome 86.0.4240.111
@yoyo837
Copy link
Contributor

yoyo837 commented Nov 18, 2020

Seem similar as #27798

@AlanCutFlim
Copy link
Contributor Author

AlanCutFlim commented Nov 18, 2020

@yoyo837 Kind weird, if you change the start date after that, the hoverRange border gets normal again. Hope it can help you

normal111

@xrkffgg xrkffgg added 🐛 Bug Ant Design Team had proved that this is a bug. 💄 style less css labels Nov 18, 2020
@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Mar 14, 2022
@github-actions
Copy link
Contributor

Hello @AlanCutFlim. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @AlanCutFlim,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

@zombieJ
Copy link
Member

zombieJ commented Feb 20, 2024

Picker component has been refactor in 5.14.0, and this issue is discussed and handled with react-component/picker#691 which will be marked as closed.

Please feel free to create new issue if you have any further question :)

Picker 组件于 5.14.0 版本进行了重构,此问题已被 react-component/picker#691 中进行讨论与处理。

如果有任何问题,欢迎随时创建新的 issue :)

@zombieJ zombieJ closed this as completed Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive 💄 style less css
Projects
None yet
Development

No branches or pull requests

6 participants