Modal Children not destory when use ({visible && <Content />})

[cxyxc]

• I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Steps to reproduce

When 4.9.1 I can use (visible && <ChildrenContent/>) in Modal, but 4.9.2 is useless. I should use destoryOnClose but too many code to transform.

I think this commit have an impact on this issue. Please help me. Thanks very much.

优化 Modal useModal 性能，避免元素渲染导致组件渲染。#28122 @TotooriaHyperion

What is expected?

I can use (visible && <ChilerenContent />) to destory my component.

What is actually happening?

I can not

Environment	Info
antd	4.9.2
React	16.x/17.x
System	mac
Browser	chrome

[fsyud]

I have the same problem

[shaodahong]

It's cause by react-component/dialog#212, @zombieJ

[TotooriaHyperion]

@cxyxc
#28122 only affects usage of

const [modal] = Modal.useModal();
return <button onClick={() => modal.confirm(...)}>Confirm</button>

check
react-component/dialog#212
this wraps content into a MemoChildren, and prevent any update triggered by visible change.

[shangyilim]

@cxyxc you could use the forceRender to rerender the child:

<Dialog forceRender >
{visible && <ChildrenContent/>}
</Dialog>

[gmoniava]

@zombieJ @shangyilim I have same problem, react-component/dialog#212, was a breaking change,
it broke some my apps where I used to rely that

visible && <ChildrenContent/>

would unmount <ChildrenContent/> on change of visible, but now it doesn't anymore. So it broke my apps where I had that assumption.

[afc163]

Sorry, you should use destoryOnClose in this situation.