Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal 下 destroyOnClose 属性 失效 #28847

Open
1 task
wansuiasdn opened this issue Jan 13, 2021 · 5 comments
Open
1 task

Modal 下 destroyOnClose 属性 失效 #28847

wansuiasdn opened this issue Jan 13, 2021 · 5 comments
Assignees
Labels
🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive

Comments

@wansuiasdn
Copy link

wansuiasdn commented Jan 13, 2021

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

https://fvrw0.csb.app/

Steps to reproduce

modal下使用video标签,播放后,关闭modal video or audio标签依然播放, 且重新打开modal 依然存在

What is expected?

modal关闭后销毁媒体标签

What is actually happening?

modal关闭后未销毁标签

Environment Info
antd 4.10.2
React 16.12.0
System win10
Browser firefox
@afc163 afc163 added the 🤔 Need Reproduce We cannot reproduce your problem label Jan 13, 2021
@ant-design-bot
Copy link
Contributor

Hello @wansuiasdn. Please provide a online reproduction by forking this link https://u.ant.design/codesandbox-repro or a minimal GitHub repository. Issues labeled by Need Reproduce will be closed if no activities in 3 days.

你好 @wansuiasdn, 我们需要你提供一个在线的重现实例以便于我们帮你排查问题。你可以通过点击 此处 创建一个 codesandbox 或者提供一个最小化的 GitHub 仓库。3 天内未跟进此 issue 将会被自动关闭。

@wansuiasdn
Copy link
Author

Hello @wansuiasdn. Please provide a online reproduction by forking this link https://u.ant.design/codesandbox-repro or a minimal GitHub repository. Issues labeled by Need Reproduce will be closed if no activities in 3 days.

你好 @wansuiasdn, 我们需要你提供一个在线的重现实例以便于我们帮你排查问题。你可以通过点击 此处 创建一个 codesandbox 或者提供一个最小化的 GitHub 仓库。3 天内未跟进此 issue 将会被自动关闭。

https://fvrw0.csb.app/

@afc163 afc163 removed the 🤔 Need Reproduce We cannot reproduce your problem label Jan 13, 2021
@afc163
Copy link
Member

afc163 commented Jan 13, 2021

forceRender 和 destroyOnClose 一起开启时,destroyOnClose 貌似失效了。

@afc163 afc163 added 🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. labels Jan 13, 2021
@ant-design-bot
Copy link
Contributor

Hello @wansuiasdn. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @wansuiasdn,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

@monolithed
Copy link

I confirm that destroyOnClose doesn't work. As a workaround, I've tried using getContainer and forceRender, but it didn't help. The component's state persists after closing. I don't understand how people have been living with this for two years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive
Projects
None yet
Development

No branches or pull requests

4 participants