Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link 类型的button disabled 的时候,没有disabled的样式 #35952

Closed
outNapGnaw opened this issue Jun 8, 2022 · 6 comments
Closed

link 类型的button disabled 的时候,没有disabled的样式 #35952

outNapGnaw opened this issue Jun 8, 2022 · 6 comments
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@outNapGnaw
Copy link

Reproduction link

Edit on CodeSandbox

Steps to reproduce

What is expected?

link button 有disabled样式

What is actually happening?

没有样式

Environment Info
antd 4.21.0
React 17
System mac
Browser chrome

关键PR
这个PR的disabled属性没有正确的赋值给link类型的button

@MuxinFeng
Copy link
Contributor

我来提个pr吧

@MuxinFeng
Copy link
Contributor

MuxinFeng commented Jun 8, 2022

如果加了 href 属性,那么就转换为 a 标签了,后续的disabled就不生效了。不知道这里的优先级是怎样的,如果 href 优先级高,那么最好在 md 里标注一下这会导致 disabled 不可用;如果 disabled 优先级高,那么我觉得这里没必要转换为 a 标签 了,直接强制吧 onClick 写成跳转就行了。麻烦大佬看看哈。

@MuxinFeng
Copy link
Contributor

image

@MadCcc
Copy link
Member

MadCcc commented Jun 8, 2022

如果加了 href 属性,那么就转换为 a 标签了,后续的disabled就不生效了。不知道这里的优先级是怎样的,如果 href 优先级高,那么最好在 md 里标注一下这会导致 disabled 不可用;如果 disabled 优先级高,那么我觉得这里没必要转换为 a 标签 了,直接强制吧 onClick 写成跳转就行了。麻烦大佬看看哈。

是 bug。
href 时应该当作 a 标签处理,这里缺了 disabled 样式,应该给 a 标签也加上 disabled。

@MadCcc MadCcc added help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. and removed help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. labels Jun 8, 2022
@ant-design ant-design deleted a comment from github-actions bot Jun 8, 2022
@MadCcc MadCcc added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Jun 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

Hello @outNapGnaw. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @outNapGnaw,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

@MuxinFeng
Copy link
Contributor

那我提一个吧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

No branches or pull requests

3 participants