Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

message - key of zero creates new message instead of updating #38259

Closed
ChrisHamilton91 opened this issue Oct 28, 2022 · 6 comments
Closed

message - key of zero creates new message instead of updating #38259

ChrisHamilton91 opened this issue Oct 28, 2022 · 6 comments
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@ChrisHamilton91
Copy link

Reproduction link

https://stackblitz.com/edit/react-yceue2?file=demo.tsx

Steps to reproduce

  1. Call message.open({content: "Loading...", key:0})
  2. Call message.success({content: "Success!", key:0})

What is expected?

The loading message changes to a success message

What is actually happening?

A new success message is created, and the loading message still exists.

Environment Info
antd 4.23.6
React 18.2.0
System Windows 10
Browser Firefox 106.0.2

Probably the result of checking if the key is falsey. Since number is an acceptable key type, 0 should be allowed. Discovered when using a counter to assign ids to messages, which is probably a common use case.

@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Oct 30, 2022
@github-actions
Copy link
Contributor

Hello @ChrisHamilton91. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @ChrisHamilton91,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

@kiner-tang
Copy link
Member

kiner-tang commented Oct 31, 2022

@afc163
Copy link
Member

afc163 commented Oct 31, 2022

PR is welcome

@afc163
Copy link
Member

afc163 commented Nov 1, 2022

@afc163 afc163 closed this as completed Nov 1, 2022
@kiner-tang
Copy link
Member

Fixed in https://github.com/react-component/notification/tree/v4.6.1

Do we need to send a PR update version of 'rc-notification' in 'ant-design' to fix this problem
@afc163

@afc163
Copy link
Member

afc163 commented Nov 1, 2022

No neccessary, semver version will cover 4.6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

No branches or pull requests

3 participants