Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu height in Header #38734

Closed
xataxxx opened this issue Nov 19, 2022 · 1 comment · Fixed by #38741
Closed

Menu height in Header #38734

xataxxx opened this issue Nov 19, 2022 · 1 comment · Fixed by #38741
Labels
🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@xataxxx
Copy link

xataxxx commented Nov 19, 2022

Reproduction link

https://ant.design/~demos/components-layout-demo-top

Steps to reproduce

Menu is 1px higher than Header so creates a visible 1px offset.

What is expected?

Menu to be contained in Header.

What is actually happening?

Menu is 1px higher.

Environment Info
antd 5.0.0
React 18
System macOS
Browser Chrome
@afc163 afc163 added 🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. labels Nov 19, 2022
@github-actions
Copy link
Contributor

Hello @xataxxx. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @xataxxx,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants