Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Justify and align properties are not reactive for Row #39690

Closed
KathRains opened this issue Dec 20, 2022 · 3 comments · Fixed by #39704
Closed

Justify and align properties are not reactive for Row #39690

KathRains opened this issue Dec 20, 2022 · 3 comments · Fixed by #39704
Labels
good first issue help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@KathRains
Copy link

Reproduction link

Edit on CodeSandbox

Steps to reproduce

  1. Create a row with align and justify properties lined to the variables.
  2. Change the variables with some UI (like in our example, we use Select)

What is expected?

The align and justify of Row should change reactively

What is actually happening?

They don't

Environment Info
antd 5.0.7
React 18.0.0
System Windows 7
Browser 108.0.5359.125

Other properties like gutter work reactively.

@github-actions
Copy link
Contributor

You may look for issues:

  1. 50% Responsive Row align and justify props #37851

🤖 By issues-similarity-analysis

@afc163 afc163 added help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. good first issue labels Dec 21, 2022
@github-actions
Copy link
Contributor

Hello @KathRains. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @KathRains,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

@candy4290
Copy link
Contributor

candy4290 commented Dec 21, 2022

I want to has a try, Can I pick up this task? @afc163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants