Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table Column 的filtered只有第一次设置时生效的，后面在更改就不生效了 #39740

Closed
Edric-Li opened this issue Dec 22, 2022 · 4 comments · Fixed by #39883
Closed

Table Column 的filtered只有第一次设置时生效的，后面在更改就不生效了 #39740

Edric-Li opened this issue Dec 22, 2022 · 4 comments · Fixed by #39883
Labels
🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. 👷🏻‍♂️ Someone working on it

Comments

@Edric-Li
Copy link

Reproduction link

Edit on CodeSandbox

Steps to reproduce

点击Set按钮，会切换 filtered 的值

What is expected?

表头的筛选高亮效果动态的消失或显示

What is actually happening?

一旦显示，再也不会消失了

Environment Info
antd 5.1.0
React 18
System Windows
Browser Chrome

我的筛选情况比较复杂，是自定义筛选，大概功能有，等于不等于，包含不包含等，就是数据库查询那一套东西，in like等，但是现在这个高亮效果没办法设置上。
@Edric-Li
Copy link
Author

希望官方能尽快确认一下这个bug，是否能修复，因为下周就内测了，是否可以修复，希望官方先给个消息，哪怕后边在修也是可以的，拜托了...

@afc163
Copy link
Member

afc163 commented Dec 22, 2022

看上去是个 bug。

@afc163 afc163 added 🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. labels Dec 22, 2022
@github-actions
Copy link
Contributor

Hello @Edric-Li. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @Edric-Li，我们完全同意你的提议/反馈，欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支（新特性发到 feature 分支，其他发到 master 分支），务必填写 Pull Request 内的预设模板，提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等，并确保 CI 通过，我们会尽快进行 Review，提前感谢和期待您的贡献。

giphy

@candy4290 candy4290 mentioned this issue Dec 23, 2022
Closed
20 tasks
@zqran
Copy link
Contributor

zqran commented Dec 24, 2022

@Edric-Li
要通过受控模式来控制筛选的话，需要添加 filteredValue 属性~ 否则，受控无效。参考：可控的筛选和排序

@yoyo837 yoyo837 mentioned this issue Dec 29, 2022
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. 👷🏻‍♂️ Someone working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix filtered update not working ant-design/ant-design
4 participants
@afc163 @heiyu4585 @zqran @Edric-Li