Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: it is difficult to distinguish whether text button with danger status are clicked #46288

Closed
zh-lx opened this issue Dec 6, 2023 · 3 comments
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. improvement improve some features Inactive

Comments

@zh-lx
Copy link
Contributor

zh-lx commented Dec 6, 2023

What problem does this feature solve?

At present, the hover and active styles of text button with danger status are exactly the same. It is difficult to distinguish whether text button with danger status are clicked.

https://stackblitz.com/edit/react-1nvbcp?file=demo.tsx

What does the proposed API look like?

The hover and active styles of text button with danger status should be different.

Copy link

stackblitz bot commented Dec 6, 2023

Fix this issue in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

@zombieJ zombieJ added improvement improve some features and removed unconfirmed labels Dec 6, 2023
@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label May 9, 2024
Copy link
Contributor

github-actions bot commented May 9, 2024

Hello @zh-lx. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @zh-lx,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

@LonelySnowman
Copy link
Contributor

我有意向完成这个 PR

@afc163 大佬目前缺一个 colorErrorBgActive 的 token,这个 active 状态用 errorColors 几号色比较合适啊。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. improvement improve some features Inactive
Projects
None yet
Development

No branches or pull requests

4 participants